From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: some accept-process-output races fixed; Tramp FIXMEs
Date: Tue, 22 Jan 2019 17:06:40 -0500 [thread overview]
Message-ID: <jwv5zug8i46.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <875zujlkhv.fsf@gmx.de> (Michael Albinus's message of "Sun, 20 Jan 2019 10:57:16 +0100")
> IIRC, the timeout is used because accept-process-output could be blocked
> otherwise. Tramp has often the need to check whether there is still
> output from the process, and the timeout is the only way I know that
> accept-process-output returns in finite time.
The time out makes sense when you have *other* things to do (so you're
just polling, making sure those other things don't prevent Emacs from
processing the process/connection's output in a timely fashion).
> If we could guarantee that (accept-process-output p) returns when
> either output has arrived and or the process has finished, I could
> change the code.
This has been the promise of the docstring "for ever", AFAIK.
Which means that if you have nothing else to do until the process dies,
then you're better off using nil for the timeout.
I don't know if that promise was broken by bugs in the code, OTOH.
Stefan
next prev parent reply other threads:[~2019-01-22 22:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 18:33 some accept-process-output races fixed; Tramp FIXMEs Paul Eggert
2019-01-16 8:32 ` Michael Albinus
2019-01-16 8:38 ` Paul Eggert
2019-01-16 8:49 ` Michael Albinus
2019-01-16 13:03 ` Michael Albinus
2019-01-16 13:25 ` Stefan Monnier
2019-01-16 18:39 ` Paul Eggert
2019-01-16 19:07 ` Stefan Monnier
2019-01-17 0:15 ` Paul Eggert
2019-01-20 9:57 ` Michael Albinus
2019-01-21 23:02 ` Daniel Colascione
2019-01-22 16:54 ` Eli Zaretskii
2019-01-22 7:09 ` Paul Eggert
2019-01-22 16:56 ` Eli Zaretskii
2019-01-22 18:58 ` Michael Albinus
2019-01-22 22:06 ` Stefan Monnier [this message]
2019-01-22 22:45 ` Michael Albinus
2019-01-23 16:18 ` Eli Zaretskii
2019-01-23 18:35 ` Michael Albinus
2019-01-23 22:19 ` Daniel Pittman
2019-01-23 16:47 ` Stefan Monnier
2019-01-23 17:36 ` Paul Eggert
2019-01-28 15:37 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5zug8i46.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).