From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt Date: Sun, 16 Jun 2019 16:24:00 -0400 Message-ID: References: <20190616141010.24607.84378@vcs0.savannah.gnu.org> <20190616141013.5EE5F20B45@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161351"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 22:24:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcbhq-000fpp-8T for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 22:24:50 +0200 Original-Received: from localhost ([::1]:42706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcbho-0003su-PQ for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 16:24:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53795) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcbh8-0003gT-2L for emacs-devel@gnu.org; Sun, 16 Jun 2019 16:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcbh7-0006Vf-3I for emacs-devel@gnu.org; Sun, 16 Jun 2019 16:24:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22552) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcbh6-0006Um-Sj for emacs-devel@gnu.org; Sun, 16 Jun 2019 16:24:05 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 664D681157; Sun, 16 Jun 2019 16:24:02 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5E3B880D83; Sun, 16 Jun 2019 16:24:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560716641; bh=P5llZ4c/prjsbj8WBbmvwsRNOhc4ztHXGj3/VquEmlk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gm1r/R/WeUx0K/yRu2dPd9c85cJSGINIl2L8t4BXeZ1yxAP0jzQwaYnyJhPXMH3Vs 4/D+lXv213SdAZCoAFZMfFVVB2hpnDLeWkZWF71uw3TtZ+JgfH9Phdv+TGy2z4W8P/ 1n6sYLLS4VrFQwEC1nSGID4QyFYiJ/jK0N9hVcZ7RwRhhR4fjStxhKZ39gHd3Q31kz IchuJQvvPXIGpEGm1oiVmjSxftoApW+GAlvHZG4Lwcxslgfo75T7ln3m6vtiQCKGkr eJB4D/QMRC1uTfNr4PMxtm/Rzpiiw02gqISozM3vPuOx4vHMiu7D0TXm3hDiTjZPsC FG5/yjEVloXeA== Original-Received: from alfajor (unknown [157.52.10.58]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2B5A21206C2; Sun, 16 Jun 2019 16:24:01 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 16 Jun 2019 21:43:24 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237747 Archived-At: >>> +(require 'cl-extra) >> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra) >> is supposed to be an internal implementation detail. > That's what I had originally, but then I got this warning: > In end of data: > emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is > not known to be defined. > Perhaps because it's an internal(ish) function? Ah, yes, it's not autoloaded because it's internal. I guess cl-extra is OK in that case, but please add a comment to explain it. Stefan