From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Compatibility patches for EDE / EIEIO Date: Mon, 18 Jan 2021 12:52:16 -0500 Message-ID: References: <5cf47a13-e71f-6f3b-f763-335696989942@siege-engine.com> <55bf727a-761c-ff52-7688-8946a3df1d86@gmail.com> <40993b3e-ad3f-9514-6fb3-8c0a220305db@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10750"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Eric Ludlam To: Eric Ludlam Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 18 18:54:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1YjQ-0002cj-2d for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Jan 2021 18:54:24 +0100 Original-Received: from localhost ([::1]:52782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1YjP-0008Uo-3i for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Jan 2021 12:54:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1Yha-00076N-Uy for emacs-devel@gnu.org; Mon, 18 Jan 2021 12:52:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1YhU-00020a-K8 for emacs-devel@gnu.org; Mon, 18 Jan 2021 12:52:30 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A1F8B8082E; Mon, 18 Jan 2021 12:52:18 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2A8D98063C; Mon, 18 Jan 2021 12:52:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1610992337; bh=s0Es8TDu1NpYUMU7ce0hNq0wMxdmRSeBr1u7rcw8LUg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AjtxPljjJj5/Rs7G3wUlWsCditMGbd9Uvh35x+gVGzmPzZKxDgT8Ct7vq+rhbJb8L 92jPV4NfWUWcRINGze6P3TzX/uac2BaQ7u73ujpi5hvlEJT+BC6C+xTdQZ+MmXEybO 6ReEP1vX+8L1vvPf2Sb+I/FiHNlrh5aGgxygtbDJxaaK4T4CQ4MgDp7qgDyV79GyOL QOm8uKAD0eFY/dx1yR52l+W+Rw0Jw/4P6O2LjQUqRZHkLbjWoh3pxebboWvEMPmcI6 SVaTjOae0qwzG9q4glNaNkT6ctJcdvX3mwr01ixc7PmWuaJMtF0fpHnnlbSzDbwTzk nWLpd/UacIFsA== Original-Received: from alfajor (unknown [45.72.224.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E3ECD1202FF; Mon, 18 Jan 2021 12:52:16 -0500 (EST) In-Reply-To: <40993b3e-ad3f-9514-6fb3-8c0a220305db@gmail.com> (Eric Ludlam's message of "Mon, 18 Jan 2021 11:52:32 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263156 Archived-At: > The short answer to your questions is that I'm not very familiar with how > the typing system works with the latest eieio changes. I suspect we're the two most knowledgeable about it, so if you have a doubt about one part I hope I can help. > I'm fine with the proposed use of (list-of ...) as it seems much > simpler and more obvious. OK, I've changed the code to use that. > I would expect you would want to make the same change in ede/base.el arou= nd > line 172, which is the code I used as a template to make :rules work.=A0= =A0 > Maybe something like the below patch? Looks good to me. So, I pushed the patch below, Stefan diff --git a/lisp/cedet/ede/base.el b/lisp/cedet/ede/base.el index 7799746e0c..810d6ef3bd 100644 --- a/lisp/cedet/ede/base.el +++ b/lisp/cedet/ede/base.el @@ -160,16 +160,13 @@ ede-project-placeholder ;; Projects can also affect how EDE works, by changing what appears in ;; the EDE menu, or how some keys are bound. ;; -(unless (fboundp 'ede-target-list-p) - (cl-deftype ede-target-list () '(list-of ede-target))) - (defclass ede-project (ede-project-placeholder) ((subproj :initform nil :type list :documentation "Sub projects controlled by this project. For Automake based projects, each directory is treated as a project.") (targets :initarg :targets - :type ede-target-list + :type (list-of ede-target) :custom (repeat (object :objectcreatefcn ede-new-target-custom)) :label "Local Targets" :group (targets) diff --git a/lisp/cedet/ede/proj.el b/lisp/cedet/ede/proj.el index 59628ebf4c..4af8b4104f 100644 --- a/lisp/cedet/ede/proj.el +++ b/lisp/cedet/ede/proj.el @@ -184,7 +184,7 @@ ede-proj-target-makefile commands where the variable would usually appear.") (rules :initarg :rules :initform nil - :type list + :type (list-of ede-makefile-rule) :custom (repeat (object :objecttype ede-makefile-rule)) :label "Additional Rules" :group (make)