From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Caching where-is-internal Date: Mon, 24 May 2021 16:33:30 -0400 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> <5213fac0-fcc9-a6aa-0a16-a124d9ec92bc@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 22:34:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llHHc-0000Yp-VI for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 22:34:41 +0200 Original-Received: from localhost ([::1]:37094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llHHb-00081F-Mf for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 16:34:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llHGg-0007JJ-1P for emacs-devel@gnu.org; Mon, 24 May 2021 16:33:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llHGZ-00086t-B5 for emacs-devel@gnu.org; Mon, 24 May 2021 16:33:41 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 38A4C10028B; Mon, 24 May 2021 16:33:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D718E10020E; Mon, 24 May 2021 16:33:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621888411; bh=f4p5NWk73KWdrS+cY15yI5cugWSADjK5tVRc+2+VqiI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=U69+b4BGVlo+rykH0IMKZRvrOGh55BgHkkU1v3UypeOrTyFFeTcUCvpwpqFJszUG5 hpFPDWYA0eT4QBxhbRzkFCJRH4Zn7hWMDA2DSeldvlEcwXdf6z44L9y5P+Du0TPUVT sIVuDZlzv8HRj9wDqW3UumoGRDV7TF3Cgai03OtLGqvBzX6GKVzzhi5lpYNaZKCP1N k+fde1IM/OxulT9b309YLHMBdUr14sHfIeBTOhIqnpano8M2K0NFXIoVv3cdT/BELT DWkaNi+PECcj/yCzh58Ms/PpGEzaoAiuLZia7BLfCj7k/964gwzEFKNRRmGKSAkc9I 20/9GWfeu88dg== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B75C120B01; Mon, 24 May 2021 16:33:31 -0400 (EDT) In-Reply-To: (Daniel Mendler's message of "Mon, 24 May 2021 22:07:02 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269807 Archived-At: > This makes sense. Thanks. Then we have to figure out why this spurious > cache flush happens. The cache checks that the set of active keymaps is the same as last time `where-is-internal` was called. So if the set of active keymaps is different, the cache will be flushed. Otherwise, the cache is also flushed by `set-keymap-parent` and `define-key` (search for `where_is_cache` in src/keymap.c for details). Stefan