From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Mon, 03 Jan 2022 13:38:09 -0500 Message-ID: References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> <0f492ac4-4167-5448-2c74-a5f67950eae4@yandex.ru> <2de2323b-6d34-9263-776b-dbeff036f8f4@gmx.at> <87zgog68ni.fsf@gnus.org> <8dfc6f22-d331-e7c1-b536-2d374197528f@gmx.at> <86v8z26o15.fsf@mail.linkov.net> <9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at> <86y23xuv8g.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39733"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Juri Linkov , Dmitry Gutov , Lars Ingebrigtsen , emacs-devel@gnu.org, Eli Zaretskii , sdsg@amazon.com To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 03 19:45:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4SKJ-000A5a-Rp for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 19:45:00 +0100 Original-Received: from localhost ([::1]:58528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4SKI-0003JJ-0W for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 13:44:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4SDw-0000Jb-B8 for emacs-devel@gnu.org; Mon, 03 Jan 2022 13:38:25 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4SDt-0000oA-VN; Mon, 03 Jan 2022 13:38:23 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 533D344153B; Mon, 3 Jan 2022 13:38:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3BC0A441538; Mon, 3 Jan 2022 13:38:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641235091; bh=nEDSopXtY6vLRfq3NmP+iWvt6rj4/d2VB5DYUOSlUqU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=br/a/CcTcn/4ZsBw2qa5hswbVukJHCO4G1Pi2goR98KK7yfLLW5ZQhI1a3HQN3Cmv Idju48T20YRAHmhG0bXAX350xBl9L1ntJ3jL9MTNaj8lhoybHABTJkT/aEbzCdiSFL 0I5db2DO3laU9z1+6EH5s9JOULr+VnQHVtEJGMdQJx2lP1kf5h3NajA/8tGKeW9NCb YmE53E4Vb0ohyJStxTWg/bPMsbomQXB8mIFDMQiOBdwTa9hyPYanWjgm7z43Q6Rawi 3si3WsIVRMPNDnuMKl54wbUyfaIF/6/5Dtqgh/hYa7F0/qiy3Gy3NolHHuBq6te7wF 0X6E3P2Mc3C8g== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D4ADD1203DD; Mon, 3 Jan 2022 13:38:10 -0500 (EST) In-Reply-To: (martin rudalics's message of "Mon, 3 Jan 2022 19:21:51 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284086 Archived-At: > It's not sufficiently general. For example, 'shell' first pops up the > buffer and then sets its major mode with an explanation that goes as > > ;; The buffer's window must be correctly set when we call comint > ;; (so that comint sets the COLUMNS env var properly). > (pop-to-buffer buffer) BTW, this is a problem we should fix more thoroughly. I *think* the right way to fix it is to first set the buffer in comint-mode, then display the buffer (when needed), then launch the process. Stefan