From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Findirect_function Date: Mon, 17 Jan 2022 13:16:13 -0500 Message-ID: References: <87tue61tz1.fsf@elite.giraud> <87r19a9sbk.fsf@elite.giraud> <87tue2jxn4.fsf@elite.giraud> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 17 19:19:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9WbE-00015Z-DC for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jan 2022 19:19:24 +0100 Original-Received: from localhost ([::1]:42222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9WbD-0006iQ-AC for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jan 2022 13:19:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9WYK-0004BN-JQ for emacs-devel@gnu.org; Mon, 17 Jan 2022 13:16:24 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9WYI-0001Sg-Sj for emacs-devel@gnu.org; Mon, 17 Jan 2022 13:16:24 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9592D80521; Mon, 17 Jan 2022 13:16:21 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7310C80055; Mon, 17 Jan 2022 13:16:16 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642443376; bh=CjmHzBOLxYA9goMiR67VogI/tEd+smKcbRlVCx7T/W8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nDUKYK0J/xgRtX5skSypxg/WoI1bgC+KiQrHoju2sIMBvProQceFvsWHl7JLBY5De x5K/4n0TAnymLajFHRMcS0FoFOATn/D8nTot3leV8//zwCkzDZ48hEcdLKp7Z2IBpB MiBmlfDVjLXQXXbvxVfFmczinKbtNUQa53E0ifdWIKcZpfcgDyoAa5hOJtVa4cdqn2 bGTCDWvcBIrxjcgJ05MAWssdK/GU2GUdpRjgucF4bqfbVRgHUrkANvd4QdS5AlCIQE Xehu9uY58DlJ6O486pvMR4tUIYiBVN5uK2fFQQ2YmdBXdj65VywPtWA5eK6mPQb2OV mUTdJsGlcGVXQ== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4C3761207C1; Mon, 17 Jan 2022 13:16:16 -0500 (EST) In-Reply-To: <87tue2jxn4.fsf@elite.giraud> (Manuel Giraud's message of "Mon, 17 Jan 2022 14:32:31 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284895 Archived-At: > From c0a250642dc998c35e8a3d471198fb13ff5bb54f Mon Sep 17 00:00:00 2001 > From: Manuel Giraud > Date: Mon, 17 Jan 2022 11:16:09 +0100 > Subject: [PATCH] Remove unused argument to Findirect_function. > > Use Findirect_function more where possible. > --- > src/callint.c | 2 +- > src/data.c | 8 +++----- > src/doc.c | 2 +- > src/eval.c | 36 ++++++++++-------------------------- > src/keymap.c | 2 +- > 5 files changed, 16 insertions(+), 34 deletions(-) Oh, the patch probably needs an entry etc/NEWS to say that the second arg (which was declared obsolete in Emacs-25) was now removed. Stefan