From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Thu, 19 May 2022 10:47:01 -0400 Message-ID: References: <83pmkbf5a9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22686"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 16:50:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrhTi-0005jh-BG for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 16:50:14 +0200 Original-Received: from localhost ([::1]:46530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrhTg-0007uk-8J for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 10:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrhQr-0005KS-P4 for emacs-devel@gnu.org; Thu, 19 May 2022 10:47:17 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrhQl-0000lm-2y; Thu, 19 May 2022 10:47:13 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9A44F80723; Thu, 19 May 2022 10:47:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3B19D804F6; Thu, 19 May 2022 10:47:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1652971627; bh=y2CH1ymN+Es5AaN5QAxZHW99RQ8GL2HgVUp4ZLu0PVs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=geY7J1Xn9oAk8c1FgA2ZNUNo15JJG7cluPpLvW7HBhWZ39ZmOtahGsa5hHzK3SCvc tFjyQFYHN+NnOgIqzuf8OeFaZmvwf05ZuimhVQtCrPMuCjsExROfRYv+T4UZHYwpTi tvwmrQJXb7Uv8dy9Lo/QvCjAFAzGxFPxZaZ87JV5tNm0a2v7sVVOm5UDPu/1yJT64f go3sWnGntJCpySa3WKthKY49xCeYvdSD0p/2hYT+ILloILhLca7+FNEurMXgxyPsm5 xV1JOYP6Yv0isavgN3QesUM5Gag7u1aOTD8jQLLC8wbqpFeGEEXy9U5M7ZSbwAT8Qm jaT7JTkXFVkRw== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EF33A120818; Thu, 19 May 2022 10:47:06 -0400 (EDT) In-Reply-To: (Alfred M. Szmidt's message of "Thu, 19 May 2022 02:11:14 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289965 Archived-At: > I think the modify-change-comment functionality hasn't seen much use, > and still quite confused how it is intended to work. E.g., in RCS, I > have this as the latest commit (and in log view mode): > > ---------------------------- > revision 1.3 > date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1 > Summary: this is a test message > ---------------------------- > > At the beginning of the buffer, log-view-modify-change-comment, then > you get a new buffer with the following: > > revision 1.3 > date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1 That's a bug. It should contain "Summary: this is a test message". FWIW I implemented this functionality originally for CVS and I can't remember ever testing it on another VCS, so I'm not surprised it doesn't work right for other VCS. I also remember having trouble using it last time I needed it in CVS (which was quite some years ago), so it might also be broken for CVS. :-( Stefan