From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Supporting git-send-email/hg email in VC Date: Wed, 24 Aug 2022 13:06:29 -0400 Message-ID: References: <848rndq2i7.fsf@iki.fi> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5718"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Philip Kaluderdic To: Antoine Kalmbach Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 24 19:07:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQtqe-0001I9-5H for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 19:07:24 +0200 Original-Received: from localhost ([::1]:47138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQtqd-0001xk-2x for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 13:07:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQtpt-00016p-LB for emacs-devel@gnu.org; Wed, 24 Aug 2022 13:06:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQtpr-0007yw-09 for emacs-devel@gnu.org; Wed, 24 Aug 2022 13:06:36 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F1E6E100189; Wed, 24 Aug 2022 13:06:31 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 48115100124; Wed, 24 Aug 2022 13:06:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661360790; bh=03mhzsJeLhY+/5XlLhlikP776s2u+272//trnzIZw4I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=km9y6Ia7JJ898lqha0Z5GpjN312Hac3Wmm3yCdBoK3K9SmlT7oXDKvsQ29o3XffiL tq3YaGMHuqAJvDUJXHF0xs7J7OKcJbJUHJ1ixjcFVIS+J7y4HSiWyHQlyxefTbq/PC VTozzQcYXaBlnQO/2FXO8NmAhgynGTlh7I7PxFSe4eu9Hv+r8SpZR27AfflKh+5Tz5 mSOakEjw391vApaqoqk4PbYS4/EeA+O8p48+p5wB11tX6WGt/PMgmAE6Q1cwdRdZDY J+e9QCxl5Ed5UiQakyyF/SdGghq6SDIoZm2TgOQsA/7qjZeUheuf6j9aLNHla87HdL OnI+RZ2aFhgLg== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 38EDC1204DE; Wed, 24 Aug 2022 13:06:30 -0400 (EDT) In-Reply-To: <848rndq2i7.fsf@iki.fi> (Antoine Kalmbach's message of "Wed, 24 Aug 2022 14:56:00 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294042 Archived-At: Antoine Kalmbach [2022-08-24 14:56:00] wrote: > Would it make sense for Emacs' VC to support emailing patches from > within Emacs? Yes! > The right thing would be in vc-dir-mode to prompt for a ref (branch, -1, > HEAD^, etc), I think in the general case it needs to revisions to delimit the sequence of patches. And since it's VC it'd need to take into account the various ways backends can specify such a pair of revisions, but the simplest option is really to receive the two revisions separately. > in vc-log-mode it would be to compose a set of patches from the marked > commit(s), or prompt like in vc-dir-mode for a ref to send a patch > from a user-specified ref. It might also make sense to allow it from a diff-mode buffer (in which case VC would not be involved). >> Warning! Some people think that they can get away with sending patches >> through some means other than git send-email, but you can't. Your >> patches will be broken and a nuisance to the maintainers whose inbox >> they land in. Follow the golden rule: just use git send-email. > But I find that if and only if you use git-format-patch, the end result > is pretty much the same. I'm not sure what problems they're thinking of, so maybe the "pretty much" is a problem. > If people think this would be a useful feature, I can open a bug report > to track this and start working on it. The proposed reference > implementation for Git would be to (1) ask the user for a ref (2) call > git format-patch with that (3) compose a new message in Emacs, and set > the body of the message to be the output of git-format-patch (OR attach > the file) and (4) let the MUA take it from there. Sounds good to me. Stefan