From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 9c0eec4ed8: * src/window.c (select_window): Fix assert for buffer = non-active minibuffer Date: Wed, 24 Aug 2022 22:28:38 -0400 Message-ID: References: <166092166892.21537.8779448176898902884@vcs2.savannah.gnu.org> <20220819150749.326DBC0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17900"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 25 04:29:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oR2cZ-0004WC-H0 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 04:29:27 +0200 Original-Received: from localhost ([::1]:52720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oR2cY-0004x9-EK for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 22:29:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR2bu-0004ET-2S for emacs-devel@gnu.org; Wed, 24 Aug 2022 22:28:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR2br-0007El-62 for emacs-devel@gnu.org; Wed, 24 Aug 2022 22:28:44 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7EF9A4417F9; Wed, 24 Aug 2022 22:28:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 155C24417E5; Wed, 24 Aug 2022 22:28:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661394520; bh=55Hbroy834LZEG2qgmeGblZjeZxfifPLMjl+Iu0cP6c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=k5ps6OymiYDVnT3qqzum2QFtuuUa8ppIb45QeBmDvuPU6Xl/f4xwO3hyxjSgA96rN zkJ8fnk47YO4gb932ROEOxWbVOSiGTIVQ0S1bmYxa3BS0MVdTiE+0NoB7W/JF2FRSG CAbHAHj+PbqLkO8LR8Q8A5HalRPR017eiURPX565ySoDU6foJIxk34thuSre8UvDjx CXApNG2JksHQfwDu7QkXZ4U7qFa9/IwVYms4M7oXHKlTJhBEiZNpoeokn9c8Ne/VP0 oKijlrHtf+R/zKTU+PLcbjwc+USUFYoUO5AgJl8suPP+ia/h72GJywRHqILzc3Dnsu /DbEy0aBCL5aA== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DB8161204E8; Wed, 24 Aug 2022 22:28:39 -0400 (EDT) In-Reply-To: <20220819150749.326DBC0088A@vcs2.savannah.gnu.org> (Alan Mackenzie's message of "Fri, 19 Aug 2022 11:07:49 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294057 Archived-At: Hi Alan, Alan Mackenzie [2022-08-19 11:07:49] wrote: > branch: emacs-28 > commit 9c0eec4ed86713519819b2e33dc3fff23f0e5f3d > Author: Alan Mackenzie > Commit: Alan Mackenzie > > * src/window.c (select_window): Fix assert for buffer = non-active minibuffer > --- > src/window.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/window.c b/src/window.c > index 2576b66a18..35ec2a1f90 100644 > --- a/src/window.c > +++ b/src/window.c > @@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord, > frame is active. */ > Fselect_frame (frame, norecord); > /* Fselect_frame called us back so we've done all the work already. */ > - eassert (EQ (window, selected_window)); > + eassert (EQ (window, selected_window) > + || (EQ (window, f->minibuffer_window) > + && NILP (Fminibufferp (XWINDOW (window)->contents, Qt)))); > return window; > } > else Thinking again about this patch, I wonder if it's the right behavior. I mean, in the case that your patch now allows, we return from `select-window` without having selected the requested window (we selected that window's frame, but not that actual window because it's a mini-window whose minibuffer is not currently active). I understand that it's not a good idea to select that mini-window, but maybe instead of terminating as if we'd done it, we should signal an error in that case because that window is not currently selectable, a bit like a dead window. Stefan