From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 48aacbf292 2/2: Make many seldom-used generalized variables obsolete Date: Sat, 10 Sep 2022 10:25:53 -0400 Message-ID: References: <166111278304.2846.13033924580993120733@vcs2.savannah.gnu.org> <20220821201303.AD1E6C0088A@vcs2.savannah.gnu.org> <877d2w1ua0.fsf@tcd.ie> <87pmgojy0m.fsf@gnus.org> <87tu5fzu2r.fsf@localhost> <877d2bohgm.fsf@gnus.org> <87o7vnyaon.fsf@localhost> <8735czogfr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19944"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Ihor Radchenko , "Basil L. Contovounesios" , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 10 16:26:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oX1RU-00050C-KM for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Sep 2022 16:26:44 +0200 Original-Received: from localhost ([::1]:53822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oX1RS-0005lH-US for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Sep 2022 10:26:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oX1Ql-0004PP-HL for emacs-devel@gnu.org; Sat, 10 Sep 2022 10:25:59 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oX1Qj-0006At-M3 for emacs-devel@gnu.org; Sat, 10 Sep 2022 10:25:59 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6F8A780390; Sat, 10 Sep 2022 10:25:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D8FB98043C; Sat, 10 Sep 2022 10:25:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662819954; bh=2ukAAZ2tVTHLu5DuGWSznMZxu7eZMzCEWk0IR+29h88=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dArvlblTzsweDraZ4CI7kV7ysS9xyg36zuiL95+XdJFxp8A2k/AAkgDD1PRgRNVHQ iz/h4IWJ2Q+NjsiOm7Iv5nZcWwHmzWEO0V+LtqHgAS58oD4wPTF1HmgXZFZ9RBYSbc uPelcgly4XuJgCPdEkF/B1BevBHL5H/T3YpzULUUhQfk28rZcDkZfTJH61umgFpjgg dcRqDLYKjPn0hNQtzFjEtoHu39cu+7pILWt5oC0MKN7e5e5PRap6rcCsRdcTB6RPuI ECM2MAsP+1qQHW6Cjd/yRJoK/9YmJnh4rzMWq5/q00PoXV85z3nPo5e5FUHQlV4gc+ JrWRxb400qoCg== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6C42312031C; Sat, 10 Sep 2022 10:25:54 -0400 (EDT) In-Reply-To: <8735czogfr.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 10 Sep 2022 09:07:52 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295126 Archived-At: >> Would it be possible to accept docstring in gv-define-setter and then >> display it in the help buffer for the relevant variable? > It would be possible, but then we'd just be encouraging people to write > illegible code. Largely agreed. There is some occasional need for documentation of the setter, for example we could argue that `alist-get` (when used as a gv) should document that the ALIST argument needs to be a gv-place as well. But when needed it can be added to the function's docstring. So, I'm leaning towards YAGNI. Stefan