From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Understanding end-of-defun Date: Tue, 25 Oct 2022 22:55:18 -0400 Message-ID: References: <46FF2036-9AB4-4C57-82B5-51260D287FC5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1228"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 26 04:55:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onWa3-00005w-65 for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Oct 2022 04:55:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onWZh-0000Mt-Je; Tue, 25 Oct 2022 22:55:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onWZg-0000GD-5x for emacs-devel@gnu.org; Tue, 25 Oct 2022 22:55:24 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onWZe-0007yS-QM for emacs-devel@gnu.org; Tue, 25 Oct 2022 22:55:23 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BEF30807D5; Tue, 25 Oct 2022 22:55:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 54C9B805B2; Tue, 25 Oct 2022 22:55:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666752920; bh=kKqJHmUVowo5arpdrfl/wd3gpK4LXCBqT5fP3zVIIU0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UvhP4NAK6buWHnwox3f1WKuEj082AG9UGr0UNQx+0oAKCRJ+SICDhmLDM4vowaviR TKFYo7oagSCt4KgV7BalcKf5qBU24jVF6mPOhTgP091rqND9W23115f6cCAOrXWT2C EdKCMKp8cE9Jlnvbn9aiLczyppL1mNsUrBx4BssSQ4zjoRGUASaft4pVSX6ZnyzpNE kPbq5CZc3bf1Z8X2Ae/VIAM7focdtK3QI2jhCQdtRx3A+2VOlt2paLOW5iJNYgIPxe MdVnuzMo0rMavh2yg/oC72+jleBbTnk9HlSpTT+6vkWw8mRRE5LLlLaNpKU5qzADYa xYMlNw8KAX1iQ== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1F7CA120F4B; Tue, 25 Oct 2022 22:55:20 -0400 (EDT) In-Reply-To: <46FF2036-9AB4-4C57-82B5-51260D287FC5@gmail.com> (Yuan Fu's message of "Tue, 25 Oct 2022 19:22:27 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298510 Archived-At: > Presumably this makes us go to the next arg=E2=80=99h begining-of-defun, = and goes to > the end of that defun. However, what if beginning-of-defun-raw couldn=E2= =80=99t find > any defun beyond point, didn=E2=80=99t move point, and returned nil? At t= hat point > calling end-of-defun-function breaks the assumption that we only call it > when point is at the beginning of a defun. Am I missing something? No, you're quite right. We should double check that `beginning-of-defun-raw` was successful (and do something else if not). Stefan