From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2a7f01aa38: Fix initialization of module functions Date: Thu, 10 Nov 2022 09:06:35 -0500 Message-ID: References: <166807775643.29181.14745596143667535171@vcs2.savannah.gnu.org> <20221110105556.B16E8C0E4C9@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36896"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 15:07:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot8DM-0009Jq-3J for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 15:07:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot8Cb-0000uG-Uo; Thu, 10 Nov 2022 09:06:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot8CX-0000ss-Gr for emacs-devel@gnu.org; Thu, 10 Nov 2022 09:06:42 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot8CW-0003tw-3W; Thu, 10 Nov 2022 09:06:41 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9B2DD10011A; Thu, 10 Nov 2022 09:06:38 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 395DF10001C; Thu, 10 Nov 2022 09:06:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668089197; bh=9p7FbjHrY1Pq1L6mU3vvVS+A6qUt6dan0bKu7p1hCC0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ifMe73WfUJAjYEgev5brO9n5UOFErbmWJ7rek8thgLsT2+3HFg05f7ERbiGfl0o6K 4sOE2B3x8q0MZ3KvhlHSjZ0CEHxb3n5bzWdeQ1irWqvmDSsVpFcYZZ4Wxk7Sunl6oj cV8lNSi2336VOxF0HAWgmyjt+E6PGEx6DPxZ8yDV9Y0ptEgbXw1w2zy3Ac06O/kDtK Eb5H3x4dIn794ZFFF6F4lVt87ewzbC7gRPtAKg46AGcq9VFZgCNKP0ZFEsMCH3eeAG SVluIct+F246QTjspCX7d2Ckn1QvEzAV+lrwShDhTZUJZgf1g8gBsN/f2GMrhd1udN Oysh90XQUkkLQ== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E08AF120206; Thu, 10 Nov 2022 09:06:36 -0500 (EST) In-Reply-To: <20221110105556.B16E8C0E4C9@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Thu, 10 Nov 2022 05:55:56 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299487 Archived-At: > allocate_module_function (void) > { > return ALLOCATE_PSEUDOVECTOR (struct Lisp_Module_Function, > - interactive_form, PVEC_MODULE_FUNCTION); > + command_modes, PVEC_MODULE_FUNCTION); > } > > #define XSET_MODULE_FUNCTION(var, ptr) \ Usually we accompany that with a comment in the struct stating "this is the last GC-tracked field" or something like that. Stefan