From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Date: Tue, 30 Jan 2024 16:41:05 -0500 Message-ID: References: <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org> <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> <871q9yonl8.fsf@localhost> <87jznqve8g.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 30 22:42:11 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUvrv-00098M-9f for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jan 2024 22:42:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUvr2-0008RL-Hb; Tue, 30 Jan 2024 16:41:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUvr0-0008RC-Jl for emacs-devel@gnu.org; Tue, 30 Jan 2024 16:41:14 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUvqy-000458-0B for emacs-devel@gnu.org; Tue, 30 Jan 2024 16:41:14 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 340661000DA; Tue, 30 Jan 2024 16:41:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706650865; bh=P6+fUeYeSVWLlgGE68l/mTCsxO7ozh4HHnXD7p5U3qY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=efbHPUhi5327tA6oQmwkI09QJxY4SopymNIMI2DCKjO2gxcxdyAKB0LuqKp6CFkXf B/1XjAGUCMC4F8KEVUbmLIBV3y8wrNbMtJ/ecUxBk0et2Th2dLWw6Zen0ChpmIvqLW 0h1h81y3zB/RA/JyZBqrS/O2+DRLmonLIz7QTsYj3bu8MYe4KxJlA9otzvQOa2tgMZ TzaL55F2nsakmi6V2vdEOwpqxk4mYc71InzA+PICc9srFwKkkjnz40MCO+pEMhU7Ua FCHWWojtte1bvNE1091nYvAsOmHbqlG4LgNQvbr5XdPe1Ingqi5UUnzJhMlWHqPNW9 dzb+ebNKJAkQg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E1734100054; Tue, 30 Jan 2024 16:41:05 -0500 (EST) Original-Received: from pastel (104-222-119-131.cpe.teksavvy.com [104.222.119.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C3A1F120490; Tue, 30 Jan 2024 16:41:05 -0500 (EST) In-Reply-To: <87jznqve8g.fsf@localhost> (Ihor Radchenko's message of "Tue, 30 Jan 2024 18:59:59 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315643 Archived-At: Ihor Radchenko [2024-01-30 18:59:59] wrote: > Stefan Monnier writes: >>> I am wondering if byte-compiler can somehow detect such scenarios and >>> throw a warning. >> >> In theory, if you "fix" the code as I suggested and call `obe-citations` >> from outside of `org-bibtex-goto-citation`., the byte-compiler could >> emit a warning. Is that what you mean? > > I mean an opposite: if `declare-function' is called globally, but the > actual function is only called by a single function in the file, emit > warning. I see. Not sure it would be very useful: the issue is not "it's only used here" but "it's only *available* here" (because of the `require`). Stefan