From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/debbugs b8c84dbe4b: Improve needed advice Date: Thu, 12 Sep 2024 15:52:08 -0400 Message-ID: References: <172615161464.14411.6152144440040360858@vcs2.savannah.gnu.org> <20240912143335.15DACC41F2A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29208"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 12 21:53:19 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sopsU-0007Qa-R0 for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Sep 2024 21:53:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soprd-0008Uv-LY; Thu, 12 Sep 2024 15:52:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soprb-0008UU-G8 for emacs-devel@gnu.org; Thu, 12 Sep 2024 15:52:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soprZ-0001gx-NO for emacs-devel@gnu.org; Thu, 12 Sep 2024 15:52:23 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F2AAE80926; Thu, 12 Sep 2024 15:52:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1726170729; bh=ri2vWWvoKs85iX6dLr48tihuw317Tt0+hI6S3DJ8wfI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bfN0hbExfoJspn4L9AOLaKChYLYOez2uC14wfNO2GUsHjyJ5byc1A5KCKpvP7zggc 1QjNYd398QfuipADRPsZqWQNG2WaE5H1Fy2n43brqVNf5YlR4sgYc08GwlYJmff7/i EYZw8PdxI0SzQHk2GJDjtEkoMfnSTrnFx3s/8HCyFhywfsq0EymcqzI3gPQtWxf78+ Z+zCu5jcqIicUCgFYsy2PGj6IUXUY56T6kXA3v8cfdR8tXAVm82RR4OkfDEpLl1llc kqGAjPRvyZoS5UjSnwXOIHIzYv2kvd95L8QraBvIUYvyofw9GE/vM6PbMyjOZl3QFP XAUlnTJLwM+Dg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7853E802A9; Thu, 12 Sep 2024 15:52:09 -0400 (EDT) Original-Received: from pastel (104-195-251-139.cpe.teksavvy.com [104.195.251.139]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 53BF6120682; Thu, 12 Sep 2024 15:52:09 -0400 (EDT) In-Reply-To: <20240912143335.15DACC41F2A@vcs2.savannah.gnu.org> (Michael Albinus via's message of "Thu, 12 Sep 2024 10:33:34 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323568 Archived-At: Hi Michael, > +(defvar debbugs-compat-url-http-attempt-keepalives nil > + "Temporary storage for `'.") > +(defun debbugs-compat-add-debbugs-advice () > + (with-no-warnings > + (setq debbugs-compat-url-http-attempt-keepalives > + url-http-attempt-keepalives)) > + (advice-add > + 'url-http-create-request :around > + (lambda (orig-fun) > + "Set `url-http-attempt-keepalives' to nil." > + (with-no-warnings (setq url-http-attempt-keepalives nil)) > + (funcall orig-fun)) > + '(name debbugs-advice))) > + > +(defun debbugs-compat-remove-debbugs-advice () > + (advice-remove 'url-http-create-request 'debbugs-advice) > + (with-no-warnings > + (setq url-http-attempt-keepalives > + debbugs-compat-url-http-attempt-keepalives))) [...] > +(defun debbugs-soap-invoke (operation-name &rest parameters) > + "Invoke the SOAP connection. > +OPERATION-NAME and PARAMETERS are as described in `soap-invoke'." > + (debbugs-compat-add-debbugs-advice) > + (prog1 > + (apply #'soap-invoke operation-name parameters) > + (debbugs-compat-remove-debbugs-advice))) I wonder you're doing it this way instead of the "more obvious": (defun debbugs-soap-invoke (operation-name &rest parameters) "Invoke the SOAP connection. OPERATION-NAME and PARAMETERS are as described in `soap-invoke'." (let ((url-http-attempt-keepalives nil)) (apply #'soap-invoke operation-name parameters))) - Stefan