From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Yuan Fu <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Sun, 08 Dec 2024 21:40:29 -0500 [thread overview]
Message-ID: <jwv5xntmvfu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1771C735-A03F-4FE5-8FCE-22F9647F4C36@gmail.com> (Yuan Fu's message of "Sun, 8 Dec 2024 17:37:59 -0800")
> I thought eval-when-compile is more of a “include if compiling” macro, should’ve checked :)
>
> We can also go with Dmitry’s idea, and just define all the functions in
> treesit.el if Emacs is not built with tree-sitter. We can detect that with
> treesit-available-p.
I haven't really thought about it, so I don't have a strong opinion.
AFAICT your proposal should work fine even if you remove the
`eval-when-compile` wrappers to which I objected. 🙂
Stefan
next prev parent reply other threads:[~2024-12-09 2:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 6:31 Use (eval-when-compile 'treesit) to save us from writing declare-function forms Yuan Fu
2024-12-03 8:30 ` Andrea Corallo
2024-12-04 18:21 ` Yuan Fu
2024-12-03 13:12 ` Eli Zaretskii
2024-12-04 18:19 ` Yuan Fu
2024-12-04 18:57 ` Eli Zaretskii
2024-12-05 6:25 ` Yuan Fu
2024-12-05 7:07 ` Eli Zaretskii
2024-12-07 1:12 ` Yuan Fu
2024-12-07 7:51 ` Eli Zaretskii
2024-12-07 13:47 ` Stefan Monnier
2024-12-08 6:39 ` Yuan Fu
2024-12-08 7:20 ` Eli Zaretskii
2024-12-08 15:27 ` Stefan Monnier
2024-12-09 1:37 ` Yuan Fu
2024-12-09 2:40 ` Stefan Monnier [this message]
2024-12-11 1:57 ` Dmitry Gutov
2024-12-08 16:01 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5xntmvfu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).