From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Herbert Euler" <herberteuler@hotmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Wrong comment in keymap.c
Date: Sun, 25 Mar 2007 21:49:39 -0400 [thread overview]
Message-ID: <jwv4po8epys.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <BAY143-F35EEC78EF2E0FDE64B488CDA6A0@phx.gbl> (Herbert Euler's message of "Fri\, 23 Mar 2007 09\:25\:49 +0800")
> Here is another one, for `read_key_sequence' in keyboard.c.
> `first_binding' is always used with `submaps', shouldn't the
> comment for it be `submaps', rather than `defs'?
No, the comment is correct. The "submaps[first_binding]" expressions are
used to check whether that first binding is a prefix or not. I.e. kind of
like "KEYMAPP (defs[first_binding])".
It's mostly set in follow_key:
if (! NILP (defs[i]))
first_binding = i;
-- Stefan
next prev parent reply other threads:[~2007-03-26 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 12:37 Wrong comment in keymap.c Herbert Euler
2007-03-23 1:25 ` Herbert Euler
2007-03-26 1:49 ` Stefan Monnier [this message]
2007-03-26 4:24 ` Herbert Euler
2007-03-26 5:50 ` Herbert Euler
2007-03-26 6:00 ` Herbert Euler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4po8epys.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=herberteuler@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).