From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; wrong-type-argument number-or-marker-p nil while trying to edit abbrevs Date: Sun, 18 Nov 2007 14:32:24 -0500 Message-ID: References: <87ve81bz4m.fsf@offby1.atm01.sea.blarg.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195414367 11053 80.91.229.12 (18 Nov 2007 19:32:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Nov 2007 19:32:47 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Eric Hanchrow Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 18 20:32:52 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Itpsx-00011c-CL for ged-emacs-devel@m.gmane.org; Sun, 18 Nov 2007 20:32:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Itpsj-0004Qm-P8 for ged-emacs-devel@m.gmane.org; Sun, 18 Nov 2007 14:32:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Itpse-0004L0-Ou for emacs-devel@gnu.org; Sun, 18 Nov 2007 14:32:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Itpsc-0004DQ-07 for emacs-devel@gnu.org; Sun, 18 Nov 2007 14:32:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Itpsb-0004D8-N9 for emacs-devel@gnu.org; Sun, 18 Nov 2007 14:32:29 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Itpsb-0005J7-Ez for emacs-devel@gnu.org; Sun, 18 Nov 2007 14:32:29 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Itpsb-0001GE-5k for emacs-pretest-bug@gnu.org; Sun, 18 Nov 2007 14:32:29 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1ItpsY-0005Ib-SE for emacs-pretest-bug@gnu.org; Sun, 18 Nov 2007 14:32:29 -0500 Original-Received: from tomts25.bellnexxia.net ([209.226.175.188] helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ItpsY-0005IJ-Jl for emacs-pretest-bug@gnu.org; Sun, 18 Nov 2007 14:32:26 -0500 Original-Received: from ceviche.home ([70.55.80.136]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071118193225.VHTT19497.tomts25-srv.bellnexxia.net@ceviche.home> for ; Sun, 18 Nov 2007 14:32:25 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 06EAFB42CC; Sun, 18 Nov 2007 14:32:24 -0500 (EST) In-Reply-To: <87ve81bz4m.fsf@offby1.atm01.sea.blarg.net> (Eric Hanchrow's message of "Fri, 16 Nov 2007 14:32:09 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83555 gmane.emacs.pretest.bugs:20306 Archived-At: > I saw > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) > define-abbrev([0 0 0 0 0 0 0 0 0 rho 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...] "rho" "right-hand opponent" nil 1 nil) > apply(define-abbrev [0 0 0 0 0 0 0 0 0 rho 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...] ("rho" "right-hand opponent" nil 1 nil)) > define-abbrev-table(outline-mode-abbrev-table (("rho" "right-hand opponent" nil 1 nil) ("pseudocode" "pseudo code" nil 0 nil) ("consitute" "constitute" nil 0 nil))) > define-abbrevs(t) > edit-abbrevs-redefine() > call-interactively(edit-abbrevs-redefine) I installed the patch below which should fix this bug, Stefan Index: lisp/abbrev.el =================================================================== RCS file: /sources/emacs/emacs/lisp/abbrev.el,v retrieving revision 1.63 diff -u -r1.63 abbrev.el --- lisp/abbrev.el 16 Nov 2007 18:27:06 -0000 1.63 +++ lisp/abbrev.el 18 Nov 2007 19:31:16 -0000 @@ -524,8 +519,14 @@ (defun clear-abbrev-table (table) "Undefine all abbrevs in abbrev table TABLE, leaving it empty." (setq abbrevs-changed t) - (dotimes (i (length table)) - (aset table i 0))) + (let* ((sym (intern-soft "" table))) + (dotimes (i (length table)) + (aset table i 0)) + ;; Preserve the table's properties. + (assert sym) + (intern sym table) + (abbrev-table-put table :abbrev-table-modiff + (1+ (abbrev-table-get table :abbrev-table-modiff))))) (defun define-abbrev (table name expansion &optional hook &rest props) "Define an abbrev in TABLE named NAME, to expand to EXPANSION and call HOOK.