unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org, Miles Bader <miles@gnu.org>
Subject: Re: C-u prefix behavior of TAB broken
Date: Thu, 20 Dec 2007 19:20:28 -0500	[thread overview]
Message-ID: <jwv4pecnbsg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4766C7F7.5060504@gmx.at> (martin rudalics's message of "Mon, 17 Dec 2007 20:03:19 +0100")

>> I'm not sure what you mean... maybe my explanation was poor, but the
>> above is what I'm referring to.

> I thought you had a less rigid version of that.

>> Anyway, that feature is now broken.

> FWIW in lisp-mode it's due to that change:

> 2007-09-19  Stefan Monnier  <monnier@iro.umontreal.ca>

>         ...

> 	* emacs-lisp/lisp-mode.el (lisp-mode-shared-map): Use the default TAB
> 	binding, so tab-always-indent works right.

It may be the superficial reason for it, but it shouldn't be the root
cause for it: indent-for-tab-command used to pass the C-u prefix to the
indent-line-function.

This said, IMNSHO the feature we're talking about shouldn't be implement
in lisp-mode and c-mode but directly generically in
indent-for-tab-command.

I use the following code in my local version of indent-for-tab-command
for that purpose:

  (cond
   [...]
   (arg
    (let ((old-indent (current-indentation)))
      (if (eq (indent-according-to-mode) 'noindent)
	  (funcall (default-value 'indent-line-function)))
      (let ((new-indent (current-indentation))
	    (beg (line-beginning-position 2))
	    (end (save-excursion (beginning-of-line)
				 (forward-sexp 1)
				 (point))))
	(when (and (> end beg) (/= new-indent old-indent))
	  (indent-code-rigidly beg end (- new-indent old-indent))))))
   [...])



        Stefan

  reply	other threads:[~2007-12-21  0:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16 22:07 C-u prefix behavior of TAB broken Miles Bader
2007-12-17 12:48 ` martin rudalics
2007-12-17 14:27   ` Miles Bader
2007-12-17 19:03     ` martin rudalics
2007-12-21  0:20       ` Stefan Monnier [this message]
2007-12-21 19:49         ` Richard Stallman
2007-12-22  0:11           ` Miles Bader
2007-12-22  9:28             ` martin rudalics
2007-12-22 13:48               ` Miles Bader
2007-12-22 17:41                 ` martin rudalics
2007-12-22 19:52                   ` Miles Bader
2007-12-22 22:35                     ` martin rudalics
2007-12-22 22:59                       ` Miles Bader
2008-02-24 19:05                         ` Juri Linkov
2008-02-24 19:26                           ` Miles Bader
2008-02-24 19:40                             ` Juri Linkov
2008-02-25  2:56                               ` Miles Bader
2007-12-23  0:55                   ` Stefan Monnier
2007-12-23  1:39                     ` Miles Bader
2007-12-23 21:49                       ` Stefan Monnier
2007-12-22 21:08               ` Richard Stallman
2007-12-22 22:08                 ` martin rudalics
2007-12-23 21:11                   ` Richard Stallman
2007-12-23 21:44                     ` martin rudalics
2007-12-24 21:55                       ` Richard Stallman
2007-12-24 22:33                         ` martin rudalics
2007-12-26  5:29                           ` Richard Stallman
2007-12-26 13:49                             ` Vinicius Jose Latorre
2007-12-26 21:26                               ` Richard Stallman
2007-12-27 20:19                             ` Juri Linkov
2007-12-28 13:55                               ` Richard Stallman
2007-12-28 13:55                               ` Richard Stallman
2008-01-03 21:52                                 ` Juri Linkov
2008-01-03 23:50                                   ` Miles Bader
2007-12-23  0:51               ` Stefan Monnier
2007-12-23  9:13                 ` martin rudalics
2007-12-26  3:00           ` Miles Bader
2007-12-18  2:24     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4pecnbsg.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).