From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: easy-menu subtlety Date: Wed, 20 Feb 2008 13:02:06 -0500 Message-ID: References: <200802201601.m1KG19WW029916@sallyv1.ics.uci.edu> <200802201720.m1KHKUcw005263@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203530608 11940 80.91.229.12 (20 Feb 2008 18:03:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Feb 2008 18:03:28 +0000 (UTC) Cc: Andreas Schwab , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 20 19:03:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JRtI8-0002lw-OB for ged-emacs-devel@m.gmane.org; Wed, 20 Feb 2008 19:03:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JRtHd-0002jY-Va for ged-emacs-devel@m.gmane.org; Wed, 20 Feb 2008 13:03:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JRtGk-0002LA-EL for emacs-devel@gnu.org; Wed, 20 Feb 2008 13:02:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JRtGj-0002JL-0S for emacs-devel@gnu.org; Wed, 20 Feb 2008 13:02:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JRtGi-0002J9-Ic for emacs-devel@gnu.org; Wed, 20 Feb 2008 13:02:08 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JRtGi-0004Sz-6j for emacs-devel@gnu.org; Wed, 20 Feb 2008 13:02:08 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAG/6u0fO+J2cdGdsb2JhbACQUgEwn2qBAQ X-IronPort-AV: E=Sophos;i="4.25,382,1199682000"; d="scan'208";a="14757406" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 20 Feb 2008 13:02:07 -0500 Original-Received: from pastel.home ([206.248.157.156]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id AUW26107; Wed, 20 Feb 2008 13:02:07 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 02A4B7F48; Wed, 20 Feb 2008 13:02:07 -0500 (EST) In-Reply-To: <200802201720.m1KHKUcw005263@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 20 Feb 2008 09:20:30 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89718 Archived-At: >> > The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el: >> > >> > ("Move" >> > ,(if (featurep 'xemacs) >> > (progn >> > ["Beginning of function" verilog-beg-of-defun t] >> > ["End of function" verilog-end-of-defun t] >> > ["Mark function" verilog-mark-defun t]) >> > ["Beginning of function" beginning-of-defun t] >> > ["End of function" end-of-defun t] >> > ["Mark function" mark-defun t]) >> >> That looks completely bogus to me. The result of the evaluation of the >> form is a single vector, with the other two just thrown away. I think >> the intention was to write this: >> >> ("Move" >> ,@(if (featurep 'xemacs) >> '(["Beginning of function" verilog-beg-of-defun t] >> ["End of function" verilog-end-of-defun t] >> ["Mark function" verilog-mark-defun t]) >> '(["Beginning of function" beginning-of-defun t] >> ["End of function" end-of-defun t] >> ["Mark function" mark-defun t])) > Thanks, but it doesn't work with emacs-21: "Invalid menu item in easymenu" I don't see any good reason for it not to work. Most likely it's some silly detail somewhere. This said, I'd recommend you just remove the test and use the XEmacs side of the code, and make sure that verilog-beg-of-defun is always defined (and make it an alias to beginning-of-defun under Emacs). Stefan