From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: CVS version: message mode + flyspell terribly slow Date: Wed, 26 Nov 2008 21:52:35 -0500 Message-ID: References: <87iqqa9pc4.fsf@cyd.mit.edu> <871vwy41l2.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227754546 2855 80.91.229.12 (27 Nov 2008 02:55:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Nov 2008 02:55:46 +0000 (UTC) Cc: kzeitler@alcatel-lucent.com, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 27 03:56:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L5X3f-0007Gb-O3 for ged-emacs-devel@m.gmane.org; Thu, 27 Nov 2008 03:56:47 +0100 Original-Received: from localhost ([127.0.0.1]:44637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5X2V-0006xb-Us for ged-emacs-devel@m.gmane.org; Wed, 26 Nov 2008 21:55:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L5X2R-0006vp-VU for emacs-devel@gnu.org; Wed, 26 Nov 2008 21:55:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L5X2Q-0006tX-4c for emacs-devel@gnu.org; Wed, 26 Nov 2008 21:55:31 -0500 Original-Received: from [199.232.76.173] (port=44024 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5X2P-0006tL-Uc for emacs-devel@gnu.org; Wed, 26 Nov 2008 21:55:29 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:6601 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L5X2P-0000XX-J6 for emacs-devel@gnu.org; Wed, 26 Nov 2008 21:55:29 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEACSbLUlMCrX1/2dsb2JhbACBbdB8gn2BJA X-IronPort-AV: E=Sophos;i="4.33,672,1220241600"; d="scan'208";a="30347991" Original-Received: from 76-10-181-245.dsl.teksavvy.com (HELO pastel.home) ([76.10.181.245]) by ironport2-out.teksavvy.com with ESMTP; 26 Nov 2008 21:55:24 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 27DA48107; Wed, 26 Nov 2008 21:52:35 -0500 (EST) In-Reply-To: <871vwy41l2.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed, 26 Nov 2008 16:30:33 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106219 Archived-At: > If we want to make tool-bar-make-keymap less expensive, one way is to > cache its computed value, in the same way that we cache tool-bar image > specs. See attached patch, which seems to eliminate most of the > slowdown. Stefan, WDYT? It looks OK. But I wonder: doesn't it make image-spec-caching redundant? Stefan