Modernize the default list of archives supported by dired guesses

Modernize the default list of archives supported by dired guesses

[Antoine Levitt]

Here's a trivial patch to add 7z and unrar (both free software) to the
list of guessed archivers. Can you merge it? 

Antoine

diff --git a/lisp/dired-x.el b/lisp/dired-x.el
index ce07676..6ed3cd1 100644
--- a/lisp/dired-x.el
+++ b/lisp/dired-x.el
@@ -988,6 +988,8 @@ replace it with a dir-locals-file `./%s'"
    '("\\.lzh$" "lharc x")
    '("\\.arc$" "arc x")
    '("\\.shar$" "unshar")
+   '("\\.rar$" "unrar x")
+   '("\\.7z$" "7z x")
 
    ;; Compression.
    (list "\\.g?z$" '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))

Re: Modernize the default list of archives supported by dired guesses

[Stefan Monnier]

> Here's a trivial patch to add 7z and unrar (both free software) to the
> list of guessed archivers. Can you merge it? 

That looks right, but please whoever installs this patch, replace the
dollars with \\' in this list of regexps.


        Stefan


> diff --git a/lisp/dired-x.el b/lisp/dired-x.el
> index ce07676..6ed3cd1 100644
> --- a/lisp/dired-x.el
> +++ b/lisp/dired-x.el
> @@ -988,6 +988,8 @@ replace it with a dir-locals-file `./%s'"
>     '("\\.lzh$" "lharc x")
>     '("\\.arc$" "arc x")
>     '("\\.shar$" "unshar")
> +   '("\\.rar$" "unrar x")
> +   '("\\.7z$" "7z x")
 
>     ;; Compression.
>     (list "\\.g?z$" '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))
        

Re: Modernize the default list of archives supported by dired guesses

[Glenn Morris]

Stefan Monnier wrote:

> That looks right, but please whoever installs this patch, replace the
> dollars with \\' in this list of regexps.

I would have done, but Savannah is so slow I gave up.
(Does dired even work with filenames with embedded newlines?)

Re: Modernize the default list of archives supported by dired guesses

[Stefan Monnier]

> (Does dired even work with filenames with embedded newlines?)

Last I checked, there is some code that would allow it, but more
is missing.  Still, no excuse to use $ when \' is meant (such changes
are largely motivated by trying to make sure users see good examples).


        Stefan

Re: Modernize the default list of archives supported by dired guesses

[Glenn Morris]

Antoine Levitt wrote:

> Here's a trivial patch to add 7z and unrar (both free software) to the
> list of guessed archivers. Can you merge it? 

No, but I did commit it. :)

You have a few small changes in Emacs now. If you expect to contribute
more, you might want to think about completing a copyright assignment.

Re: Modernize the default list of archives supported by dired guesses

[Antoine Levitt]

28/02/11 08:24, Glenn Morris
> Antoine Levitt wrote:
>
>> Here's a trivial patch to add 7z and unrar (both free software) to the
>> list of guessed archivers. Can you merge it? 
>
> No, but I did commit it. :)

Ah, it seems I'm not up to date on the terminology. You commit changes
and merge commits, right?

Well, thanks for the commit, then!

> You have a few small changes in Emacs now. If you expect to contribute
> more, you might want to think about completing a copyright assignment.

Yes, I've sent the papers back last week. I'm waiting to hear from the
FSF.

Re: Modernize the default list of archives supported by dired guesses

[Glenn Morris]

Antoine Levitt wrote:

>> No, but I did commit it. :)

Actually Savannah is being slow again, so the commit is still pending. I
might have to kill it actually, since I am not sure if it is making any
progress at all...

> Ah, it seems I'm not up to date on the terminology. You commit changes
> and merge commits, right?

It's me who's not up to date. I just commit things like I used to with CVS.
None of this pushing etc nonsense.

> Yes, I've sent the papers back last week. I'm waiting to hear from the
> FSF.

Great.

Re: Modernize the default list of archives supported by dired guesses

[Richard Stallman]

Last I checked, unrar is not free software.  We are looking for
someone to write a free program to do that.

-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org

Re: Modernize the default list of archives supported by dired guesses

[Antoine Levitt]

01/03/11 19:20, Richard Stallman
> Last I checked, unrar is not free software.  We are looking for
> someone to write a free program to do that.

Apparently, most distros package http://www.unrarlib.org/faq.html, which
is GPLv2, as "unrar", so there's no problem.

Ubuntu packages this as "unrar-free", and also has an "unrar" package
which is proprietary and supports RAR 3. Both provide /usr/bin/unrar.

Re: Modernize the default list of archives supported by dired guesses

[Richard Stallman]

    Apparently, most distros package http://www.unrarlib.org/faq.html, which
    is GPLv2, as "unrar", so there's no problem.

I see.  I think this supports RAR 2 and we don't have free software
for RAR 3.

So the free unrar is ok to support for whatever good it does.


-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org

Re: Modernize the default list of archives supported by dired guesses

[Jeff Sparkes]

Antoine Levitt <antoine.levitt@gmail.com> writes:

> Here's a trivial patch to add 7z and unrar (both free software) to the
> list of guessed archivers. Can you merge it? 

On cygwin, it's "p7zip".  You could search for either 7z or p7zip.  Most
of the entries aren't validated though.  It's a shame it's not an alist.

>
> Antoine
>
> diff --git a/lisp/dired-x.el b/lisp/dired-x.el
> index ce07676..6ed3cd1 100644
> --- a/lisp/dired-x.el
> +++ b/lisp/dired-x.el
> @@ -988,6 +988,8 @@ replace it with a dir-locals-file `./%s'"
>     '("\\.lzh$" "lharc x")
>     '("\\.arc$" "arc x")
>     '("\\.shar$" "unshar")
> +   '("\\.rar$" "unrar x")
> +   '("\\.7z$" "7z x")fdired-x
>  
>     ;; Compression.
>     (list "\\.g?z$" '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))