From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115439: * autorevert.el (auto-revert-notify-add-watch): Do not handle symlinked files. Date: Mon, 09 Dec 2013 21:30:53 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386642675 10962 80.91.229.3 (10 Dec 2013 02:31:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Dec 2013 02:31:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 10 03:31:20 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqD6W-0002PL-FE for ged-emacs-devel@m.gmane.org; Tue, 10 Dec 2013 03:31:20 +0100 Original-Received: from localhost ([::1]:46901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqD6V-0004zr-UH for ged-emacs-devel@m.gmane.org; Mon, 09 Dec 2013 21:31:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqD6N-0004zk-1o for emacs-devel@gnu.org; Mon, 09 Dec 2013 21:31:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqD6C-0007Gx-BO for emacs-devel@gnu.org; Mon, 09 Dec 2013 21:31:10 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqD6C-0007Ga-6c for emacs-devel@gnu.org; Mon, 09 Dec 2013 21:31:00 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBA2UsGd017575; Mon, 9 Dec 2013 21:30:55 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 99E54AE2E5; Mon, 9 Dec 2013 21:30:53 -0500 (EST) In-Reply-To: (Michael Albinus's message of "Mon, 09 Dec 2013 14:47:05 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4787=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4787> : inlines <294> : streams <1088208> : uri <1619442> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166242 Archived-At: > + (when (or (string-match auto-revert-notify-exclude-dir-regexp > + (expand-file-name default-directory)) > + (not (file-symlink-p buffer-file-name))) I think this patch is acceptable, but if/when we try to write a generic file-watcher Elisp API, it would be good to make this work (probably by adding a watcher on the symlink's target). Stefan