From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r115439: * autorevert.el (auto-revert-notify-add-watch): Do not handle symlinked files.
Date: Mon, 09 Dec 2013 21:30:53 -0500 [thread overview]
Message-ID: <jwv4n6he8vv.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1Vq26z-00077J-TF@vcs.savannah.gnu.org> (Michael Albinus's message of "Mon, 09 Dec 2013 14:47:05 +0000")
> + (when (or (string-match auto-revert-notify-exclude-dir-regexp
> + (expand-file-name default-directory))
> + (not (file-symlink-p buffer-file-name)))
I think this patch is acceptable, but if/when we try to write a generic
file-watcher Elisp API, it would be good to make this work (probably by
adding a watcher on the symlink's target).
Stefan
next parent reply other threads:[~2013-12-10 2:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Vq26z-00077J-TF@vcs.savannah.gnu.org>
2013-12-10 2:30 ` Stefan Monnier [this message]
2013-12-10 3:49 ` [Emacs-diffs] trunk r115439: * autorevert.el (auto-revert-notify-add-watch): Do not handle symlinked files Eli Zaretskii
2013-12-10 4:58 ` Michael Albinus
2013-12-10 15:07 ` Davis Herring
2013-12-10 16:38 ` Eli Zaretskii
2013-12-11 4:36 ` Stefan Monnier
2013-12-11 15:17 ` Michael Albinus
2013-12-10 4:37 ` Michael Albinus
2013-12-10 16:38 ` Eli Zaretskii
2013-12-11 4:38 ` Stefan Monnier
2013-12-11 16:29 ` Eli Zaretskii
2013-12-11 4:37 ` Stefan Monnier
2013-12-11 15:21 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4n6he8vv.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).