From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r115470: eww: exit and close actions
Date: Thu, 12 Dec 2013 13:52:48 -0500 [thread overview]
Message-ID: <jwv4n6d7vme.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1Vqp1Z-0004La-IR@vcs.savannah.gnu.org> (Teodor Zlatanov's message of "Wed, 11 Dec 2013 19:00:45 +0000")
> +(defun eww-exit ()
> + "Exit the Emacs Web Wowser."
> + (interactive)
> + (setq eww-history nil)
> + (kill-buffer (current-buffer)))
> +
> +(defun eww-close ()
> + "Close the Emacs Web Wowser browser, leaving history intact."
> + (interactive)
> + (quit-window))
I think this is a step backward. The names `eww-close' and `eww-exit'
don't help the user understand what those commands do. To me they sound
like different names for the same thing.
I'd rather use commands `kill-this-buffer' and `quit-window' which are
much more clear and which the user might already know.
I'm not sure how (setq eww-history nil) fits in there, because I don't
know why it's there, so I can't comment on how best to go about it in
this respect.
Stefan
next parent reply other threads:[~2013-12-12 18:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Vqp1Z-0004La-IR@vcs.savannah.gnu.org>
2013-12-12 18:52 ` Stefan Monnier [this message]
2013-12-12 19:17 ` [Emacs-diffs] trunk r115470: eww: exit and close actions Ted Zlatanov
2013-12-12 22:14 ` Stefan Monnier
2013-12-13 14:36 ` Ted Zlatanov
2013-12-13 15:06 ` Stefan Monnier
2013-12-13 19:36 ` Ted Zlatanov
2013-12-14 2:07 ` Stefan Monnier
2013-12-14 17:33 ` Ted Zlatanov
2013-12-14 17:49 ` Lars Magne Ingebrigtsen
2013-12-16 0:21 ` T.V. Raman
2013-12-16 22:25 ` Ted Zlatanov
2013-12-16 22:30 ` Glenn Morris
2013-12-19 16:27 ` Ted Zlatanov
2013-12-20 0:41 ` Stephen J. Turnbull
2013-12-20 1:07 ` Ted Zlatanov
2013-12-20 11:15 ` Andreas Schwab
2013-12-20 11:32 ` Ted Zlatanov
2013-12-20 12:00 ` Stephen J. Turnbull
2013-12-20 13:12 ` Steinar Bang
2013-12-20 14:36 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4n6d7vme.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).