unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] fix/undo-point-in-wrong-place 01beb39 2/2: Store value of point at beginning of last command.
       [not found] ` <E1a0ukW-0007BU-Cd@vcs.savannah.gnu.org>
@ 2015-11-23 17:27   ` Stefan Monnier
  0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2015-11-23 17:27 UTC (permalink / raw)
  To: emacs-devel; +Cc: Phillip Lord

> +  if (last_point_position != beg &&
> +      current_buffer == prev_buffer )
> +    {
> +      record_point (last_point_position);
> +    }
 
If last_point_position really records the position of point at the
beginning of the command, then you'll get weird results if the comment
explicitly calls undo-boundary in the middle of its changes, since the
"second bundle" will end up with a spurious point movement.

I think you'd be better off just preserving the previous behavior
(i.e. make my suggested patch work and just fix the comments): less
work, and more guarantee that it won't introduce new regressions.


        Stefan



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-23 17:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20151123171755.27551.5615@vcs.savannah.gnu.org>
     [not found] ` <E1a0ukW-0007BU-Cd@vcs.savannah.gnu.org>
2015-11-23 17:27   ` [Emacs-diffs] fix/undo-point-in-wrong-place 01beb39 2/2: Store value of point at beginning of last command Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).