unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Philipp Stephani <phst@google.com>
Subject: Re: [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mouse mode
Date: Tue, 22 Nov 2016 20:08:27 -0500	[thread overview]
Message-ID: <jwv4m2zgg0u.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20161122204222.DBE712201C5@vcs.savannah.gnu.org> (Philipp Stephani's message of "Tue, 22 Nov 2016 20:42:22 +0000 (UTC)")

> +	(setf (terminal-parameter nil 'xterm-mouse-last-down)
> +              ;; EVENT might be handed back to the input queue, which
> +              ;; might modify it.  Copy it into the terminal parameter
> +              ;; to guard against that.
> +              (copy-sequence event))

Do you have further information about when/where events might be
modified in place?  It sounds like a risky operation.


        Stefan



       reply	other threads:[~2016-11-23  1:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161122204222.29398.86534@vcs.savannah.gnu.org>
     [not found] ` <20161122204222.DBE712201C5@vcs.savannah.gnu.org>
2016-11-23  1:08   ` Stefan Monnier [this message]
2016-11-23 12:20     ` [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mouse mode Philipp Stephani
2016-11-23 15:54       ` Eli Zaretskii
2016-11-23 17:09         ` Philipp Stephani
2016-11-23 17:22           ` Eli Zaretskii
2016-11-24  8:58             ` Philipp Stephani
2016-11-24 16:23               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4m2zgg0u.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).