unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: elpa.gnu.org packages requiring external packages
Date: Wed, 31 Jan 2018 18:11:22 -0500	[thread overview]
Message-ID: <jwv4ln17ks7.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87h8r1lxy8.fsf@ericabrahamsen.net

>>>>     > ebdb-i18n-chn    # needs "pyim"
>> BTW, I think Emacs comes with 99% of what's needed already (it does
>> have a pinyin table and looking at pyim-hanzi2pinyin, there doesn't
>> seem to be much more to it), so maybe we could add to Emacs a function
>> equivalent to pyim-hanzi2pinyin and get rid of this dependency.
> I'll take a look and see how close it already is. I'd be happy to add a
> function to Emacs to do this or, if it's a real no-brainer, just add it
> to EBDB and remove this dependency (and probably the whole package).

AFAICT the pinyin table is only kept in the quail table: quail tables
are somewhat similar to keymaps, so they work well to incrementally map
a sequence of ASCII chars to the possible chinese characters, but for
pyim-hanzi2pinyin we'll need to traverse this table to build a "reverse
table" (most likely represented as a char-table).

>> IOW if we could get rid of the second dependency, then I think it would
>> make sense to remove `helm` as a dependency (and probably just merge
>> helm-ebdb into ebdb).  So my question here is: why do we need to call
>> helm-marked-candidates?
>
> I don't quite understand -- the package is useless without the call to
> `helm-other-buffer' (that's the whole point), so how could I remove
> that, or fold this into ebdb?

The helm-ebdb function is useless without Helm, yes.  But that doesn't
mean that it has to appear as a dependency on the containing package.

Imagine if font-lock, outline, newcomment, and indent were packaged as
ELPA packages.  Would you want separate python-font-lock,
python-outline, python-comment, and python-indent packages each with its
corresponding dependency?

I think it makes a lot of sense to fold helm-ebdb into the ebdb package,
without adding `helm` as a dependency.  This way, users of Helm and EBDB
won't have to additionally install helm-ebdb to enjoy the combination of
the two: just by installing `ebdb` and `helm` they'll get `helm-ebdb`.

> I think the only way around that would be to ask the helm maintainers to
> allow some sort of flag to be set in the alist definition, saying "these
> actions should accept all the marked candidates".

Something along these lines sounds good, yes.

> I'm not too optimistic they'd do that.

Why not?


        Stefan




  reply	other threads:[~2018-01-31 23:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  7:22 elpa.gnu.org packages requiring external packages Glenn Morris
2018-01-30 14:08 ` Richard Stallman
2018-01-30 14:28   ` Eric Abrahamsen
2018-01-30 16:13     ` Stefan Monnier
2018-01-31 17:50       ` Eric Abrahamsen
2018-01-31 23:11         ` Stefan Monnier [this message]
2018-02-01 17:54           ` Eric Abrahamsen
2018-02-01 19:23             ` Stefan Monnier
2018-02-03  0:43               ` Eric Abrahamsen
2018-02-04 20:16                 ` Dmitry Gutov
2018-02-06 19:45                   ` Eric Abrahamsen
2018-02-02 13:49         ` Feng Shu
2018-02-02 16:12           ` Stefan Monnier
2018-01-31  1:25     ` Richard Stallman
2018-01-30 19:04 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4ln17ks7.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).