From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633) Date: Tue, 27 Feb 2018 21:03:03 -0500 Message-ID: References: <20180228012154.1636.19993@vcs0.savannah.gnu.org> <20180228012156.38869207B1@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519783288 16847 195.159.176.226 (28 Feb 2018 02:01:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2018 02:01:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "=?windows-1252?Q?Fabi=E1n?= E. Gallina" , Michael Albinus , emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 03:01:23 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqr3a-0003nZ-Qf for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 03:01:22 +0100 Original-Received: from localhost ([::1]:41389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqr5d-0004v1-Bh for ged-emacs-devel@m.gmane.org; Tue, 27 Feb 2018 21:03:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqr5P-0004sS-WC for emacs-devel@gnu.org; Tue, 27 Feb 2018 21:03:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqr5P-00009C-8G for emacs-devel@gnu.org; Tue, 27 Feb 2018 21:03:16 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqr5L-00006l-H6; Tue, 27 Feb 2018 21:03:11 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w1S234SU009291; Tue, 27 Feb 2018 21:03:04 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 06E5E606D4; Tue, 27 Feb 2018 21:03:04 -0500 (EST) In-Reply-To: <20180228012156.38869207B1@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Tue, 27 Feb 2018 20:21:55 -0500 (EST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6231=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6231> : inlines <6438> : streams <1780236> : uri <2600524> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223147 Archived-At: > Since python.el is distributed via GNU ELPA, it should be functional > in earlier Emacs versions. Also fix some compile warnings. Thanks. I have a few questions, tho: > + (unless (fboundp 'file-local-name) Regarding this function, [ I understand you didn't write this code, so the question is not necessarily for you ] I see it's used as follows: (file-name (expand-file-name (file-local-name file-name))) (temp-file-name (when temp-file-name (expand-file-name (file-local-name temp-file-name))))) I don't understand how/why it makes sense to apply expand-file-name on its return value. Shouldn't this be (file-name (file-local-name (expand-file-name file-name))) (temp-file-name (when temp-file-name (file-local-name (expand-file-name temp-file-name))))) ? > + " > +Overlapping strings detected (start=%d, last-end=%d)") You can put a \ at the end of the first line to avoid inserting a newline in the string's content. > - (set (make-local-variable 'prettify-symbols-alist) > - python--prettify-symbols-alist) > + (when (and (boundp 'prettify-symbols-alist) > + (boundp 'python--prettify-symbols-alist)) > + (set (make-local-variable 'prettify-symbols-alist) > + python--prettify-symbols-alist)) Setting prettify-symbols-alist when it's not defined should be harmless. So I'm curious what was the motivation behind the (boundp 'prettify-symbols-alist) test? Could we replace it with a (defvar prettify-symbols-alist)? [ As for python--prettify-symbols-alist, it's defined above, so it will always be 'boundp'. ] Stefan