From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Noam Postavsky <npostavs@gmail.com>
Cc: "Fabián E. Gallina" <fgallina@gnu.org>,
"Michael Albinus" <michael.albinus@gmx.de>,
"Emacs developers" <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633)
Date: Wed, 28 Feb 2018 00:10:49 -0500 [thread overview]
Message-ID: <jwv4lm1n1kl.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <CAM-tV-81_mUZrQ+y4dKC0JCvA-HazBM70hWeiPGRMSSg2kac0g@mail.gmail.com> (Noam Postavsky's message of "Tue, 27 Feb 2018 22:33:28 -0500")
> Oh, I see, in Emacs 24, the compiler doesn't realize that
> define-obsolete-variable-alias defines a variable, so it still warns
> about it. Actually, we could just use the non-obsolete
> python-prettify-symbols-alist name there, right?
Indeed, we should use the non-obsolete name (and I now see also that the
define-obsolete-variable-alias is placed after the defvar, whereas it
should always come *before* (so that, in case one of the two is already
set when we get to define-obsolete-variable-alias we can just "share"
that setting, whereas if we do it afterwards we end up having to choose
between two conflicting settings)).
Stefan
next prev parent reply other threads:[~2018-02-28 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180228012154.1636.19993@vcs0.savannah.gnu.org>
[not found] ` <20180228012156.38869207B1@vcs0.savannah.gnu.org>
2018-02-28 2:03 ` [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633) Stefan Monnier
2018-02-28 3:33 ` Noam Postavsky
2018-02-28 5:10 ` Stefan Monnier [this message]
2018-02-28 7:55 ` Michael Albinus
2018-03-02 3:15 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4lm1n1kl.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=fgallina@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).