From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps. Date: Sun, 25 Nov 2018 13:22:38 -0500 Message-ID: References: <20181117124534.GA8831@ACM> <83muq7u9rk.fsf@gnu.org> <20181123130904.GA2916@ACM> <20181125143125.GA27152@ACM> <20181125173528.GD27152@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543170082 2308 195.159.176.226 (25 Nov 2018 18:21:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2018 18:21:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: michael_heerdegen@web.de, eliz@gnu.org, "Charles A. Roelli" , cpitclaudel@gmail.com, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 25 19:21:18 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQz1x-0000Rj-J6 for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 19:21:17 +0100 Original-Received: from localhost ([::1]:60810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQz44-0006VU-63 for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 13:23:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQz3T-0006VL-3W for emacs-devel@gnu.org; Sun, 25 Nov 2018 13:22:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQz3Q-0006Pd-0P for emacs-devel@gnu.org; Sun, 25 Nov 2018 13:22:51 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQz3P-0006PZ-T1; Sun, 25 Nov 2018 13:22:47 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id wAPIMbxg001418; Sun, 25 Nov 2018 13:22:37 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 47A5CAE5E8; Sun, 25 Nov 2018 13:22:38 -0500 (EST) In-Reply-To: <20181125173528.GD27152@ACM> (Alan Mackenzie's message of "Sun, 25 Nov 2018 17:35:28 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6425=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6425> : inlines <6970> : streams <1805313> : uri <2755557> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231359 Archived-At: > symbols-with-pos-enabled gets bound to t by Lisp code (that's its point). > So Vsymbols_with_pos_enabled has to be a Lisp_Object of some sort. No, it doesn't. If you use DEFVAR_BOOL, then the underlying C var will be of type `bool` but it's still exported as a normal Elisp variable that can be `let` bound like any other (except that any non-nil value will result in the variable taking value t). > NILP won't work here (as I pointed out to Eli), because of circular > dependencies inside lisp.h. Oh, right: #define lisp_h_NILP(x) EQ (x, Qnil) Reminds me of another question I had: in your code, do you need NILP to pay attention to symbols-with-pos-enabled? That would significantly increase the impact in terms of code-size and CPU time (could explain why you see 8% slowdown which is more expansive than my patch which turns EQ into EQL). Stefan