unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: How to quickly compare equality of structs ...
Date: Tue, 07 May 2019 08:41:43 -0400	[thread overview]
Message-ID: <jwv4l66h25g.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2y33jvujk.wl%esq@lawlist.com> (Keith David Bershatsky's message of "Mon, 06 May 2019 19:59:43 -0700")

> If for example, the old cache contains a fake cursor with an x of 0 and
> a y of 3, then the key is 9.  I would search the new tentative cache for
> a key of 9

That's a for-loop over the table with 1 int-comparison per iteration.

> -- if none is found, then this fake cursor must be erased.
> If a key of 9 is found in the new tentative cache, then proceed to do one of
> the methods suggested by Paul -- i.e., "compare each member of the struct"

That's a for-loop over the table with 2 int-comparisons per iteration.

The extra comparison per iteration is likely to be negligible.

> With an arbitrary estimated need of approximately 250 or so fake cursors for
> any live window, a "for" loop to search for a unique key in the new
> tentative cache is probably sufficiently effective.  I was; however, also
> thinking about the possibility of using a key in the context of a hash table
> if that would be more prudent.

I don't know how your fake-cursors are represented in the Elisp world,
but maybe you can add to the structs in the above table a pointer back
to the corresponding Elisp data, and then you can perform a single scan
of the table and for each such cursor, check the Elisp side to see if
it's still "live".  This would avoid the lookup altogether?

I'm probably not making sense, tho, since I have no idea how your
system is structured.  Don't mind me,


        Stefan



  reply	other threads:[~2019-05-07 12:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  2:59 How to quickly compare equality of structs Keith David Bershatsky
2019-05-07 12:41 ` Stefan Monnier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-05-06 23:07 Keith David Bershatsky
2019-05-07  0:49 ` Stefan Monnier
2019-05-06 20:40 Keith David Bershatsky
2019-05-06 21:22 ` Paul Eggert
2019-05-06 18:55 Keith David Bershatsky
2019-05-06 19:00 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4l66h25g.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).