From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO. Date: Tue, 22 Sep 2020 12:22:12 -0400 Message-ID: References: <20200921144653.9320.23809@vcs0.savannah.gnu.org> <20200921144656.3E99C206ED@vcs0.savannah.gnu.org> <87zh5ihr5p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov , Stefan Kangas , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 22 18:23:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKl50-0005N6-Qj for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Sep 2020 18:23:46 +0200 Original-Received: from localhost ([::1]:38656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKl4z-0007L4-RQ for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Sep 2020 12:23:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKl3c-0005f2-A4 for emacs-devel@gnu.org; Tue, 22 Sep 2020 12:22:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKl3Z-0000Fh-4h for emacs-devel@gnu.org; Tue, 22 Sep 2020 12:22:19 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 35AC2100271; Tue, 22 Sep 2020 12:22:15 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 93FA010022A; Tue, 22 Sep 2020 12:22:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600791733; bh=xDP6IUiz5rqoEqwKoVvY/0CuHx4pTOsjvzzdHgyx6vU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YjCWHegF7Nhhn/pIs+hfp9PzuzBnZaJYWT6knVQW05F2IiU9xnbf0BhNTNS5kgenf 4+tOW8/9ovvdpyL0/ckOiTsNJ23c3qjNj28axO8SxUWqCcJBPJzk1FAj/Atk9+tfEX wu7umsacih3nBMMpShy0hqq4aIxocQXe4ZwklL8Fy4w5dozYaB9EgUrQaG5lGV+wV4 lSy8pezr6k8hQfaw4IUBGjLBGWATZEK2XDlz7O18XAWuJelNg31QQB9MELf6G3lyAa ymxBdGc9fOTXJRGi6sD/FnLbyCldH7MXRfW1BRj6L/PSplL0Ql7Q+MnFQbYg0kzQhd pPncf5BoKZqDg== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 630D51204A7; Tue, 22 Sep 2020 12:22:13 -0400 (EDT) In-Reply-To: <87zh5ihr5p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 22 Sep 2020 15:33:54 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 10:01:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256330 Archived-At: FWIW, when I saw Stefan (the other)'s change, I thought "oh well, it was bound to happen", because just like Dmitry, I find those manual tests much easier to deal with when the time comes to fix the code. But I didn't say anything because indeed, it's better if those tests are run as part of "make check". Of course, if someone could find it in their heart/schedule to write ERT tests which use the "manual" files, I'd get have my cake and eat it to. Stefan