From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 12578d6: Change how (declare (modes store the data Date: Sat, 20 Feb 2021 09:50:51 -0500 Message-ID: References: <20210220132950.31277.5100@vcs0.savannah.gnu.org> <20210220132951.6CCAF20B7C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2971"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 20 15:54:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDTe3-0000al-Pv for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 15:54:07 +0100 Original-Received: from localhost ([::1]:33100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDTe2-0005A6-RW for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 09:54:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDTb4-0001lR-4b for emacs-devel@gnu.org; Sat, 20 Feb 2021 09:51:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDTb1-0004eh-Jy for emacs-devel@gnu.org; Sat, 20 Feb 2021 09:51:01 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5DF76100240; Sat, 20 Feb 2021 09:50:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7CC471000DA; Sat, 20 Feb 2021 09:50:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613832652; bh=Ey4H6TikpG7ND3u9YhPo9jWfZbIFYo8wqPcriTnuSSo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aMrYiBYzU05ej8/pjpfY8rcLm6BmuJ/OIz9tR7+scHuUV0SIc3d3WChBmaT102dgA BoT8CxZQk/96EqCFNbS1bedeloTuLNDegNnxBk1wBAupuI5bqaANSU+P/h6y2BaYKj e1M3V5B4Wh9+Fsj9rl219BK6XNBJNmGH+UVKUJ994z4Eo8ze8qVm+qiMP5fZY6XrgO 4q9Y+YCQhB8OGbUQPeYGMANCJTo0xd6oGHfrNarMv9ytiVsFuJpzxDRgbMZTtYp98y ArMYKbP8BDGrgatTLkmdV125TiwgC5pN37q6ytiSnVhs+aXapeL4Awcnx3npqWc7MO HClxGpZgz/X9g== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 237EC1203FD; Sat, 20 Feb 2021 09:50:52 -0500 (EST) In-Reply-To: <20210220132951.6CCAF20B7C@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 20 Feb 2021 08:29:50 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265319 Archived-At: > * lisp/emacs-lisp/byte-run.el (byte-run--set-modes): Change from > being a predicate to storing the modes. This allows using the > modes for positive command discovery, too. BTW, maybe the generalization is to replace the "completion-predicate" and the "command-modes" into a function that returns a *score*, with some convention where a score lower than X means the command can't possibly work, and score lower than Y means the command is too unlikely to be useful to be worth listing, a score higher than Y means that the command has a special affinity with the current situation (like "written for the current mode"), ... Stefan