From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Arthur Miller <arthur.miller@live.com>
Cc: emacs-devel@gnu.org
Subject: Re: Partial wdired (edit just filename at the point)
Date: Wed, 17 Mar 2021 10:09:22 -0400 [thread overview]
Message-ID: <jwv4kh9khg2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AM9PR09MB49775E560D5B1BE1DEC8DA1E966A9@AM9PR09MB4977.eurprd09.prod.outlook.com> (Arthur Miller's message of "Wed, 17 Mar 2021 14:58:47 +0100")
> The problem here is how aborting changes is implemented in wdired: undo
> is disabled and original code just copies entire buffer and pastes it back
> when changes are aborted.
I think you should be able to leave this part of the code completely unchanged.
> I would like to skip copying entire buffer into buffer-string as
> wdired does originally.
Any particular reason for that? It should be very fast, even for very
large directories.
> I agree with you, but I am not sure how to implement it. My hack was
> literally less than a 5 minute change, I just removed loops and changed
> mode name so I can abort it properly.
I'd start with the following:
When converting to wdired, instead of calling `wdired-preprocess-files`, use
(add-hook 'before-change-functions #'wdired--preprocess-lines nil t)
and then turn `wdired-preprocess-files` into `wdired--preprocess-lines`,
which will `get-text-property` of the first char of each line in the
region to see if it's already been marked as `read-only`. If yes,
do nothing and if not, do what the old code did on that line.
Stefan
next prev parent reply other threads:[~2021-03-17 14:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 18:23 Partial wdired (edit just filename at the point) Arthur Miller
2021-03-17 1:18 ` Stefan Monnier
2021-03-17 2:21 ` Arthur Miller
2021-03-17 2:34 ` Stefan Monnier
2021-03-17 13:58 ` Arthur Miller
2021-03-17 14:09 ` Stefan Monnier [this message]
2021-03-17 19:56 ` Arthur Miller
2021-03-17 22:40 ` Arthur Miller
2021-03-18 2:10 ` Stefan Monnier
2021-03-18 10:26 ` Arthur Miller
2021-03-18 10:32 ` Thierry Volpiatto
2021-03-18 11:00 ` Arthur Miller
2021-03-18 11:11 ` Thierry Volpiatto
2021-03-18 11:46 ` Arthur Miller
2021-03-23 23:32 ` Michael Heerdegen
2021-03-18 14:21 ` Stefan Monnier
2021-03-19 11:15 ` Arthur Miller
2021-03-19 16:18 ` Stefan Monnier
2021-03-19 20:40 ` Sv: " arthur miller
2021-03-19 21:58 ` Stefan Monnier
2021-03-20 11:23 ` Sv: " arthur miller
2021-03-21 22:17 ` Tomas Hlavaty
2021-03-22 8:12 ` tomas
2021-03-22 12:44 ` Arthur Miller
2021-03-22 14:50 ` tomas
2021-03-22 13:11 ` Stefan Monnier
2021-03-22 20:08 ` Tomas Hlavaty
2021-03-22 20:28 ` Andreas Schwab
2021-03-22 21:00 ` Stefan Monnier
2021-03-22 21:52 ` Tomas Hlavaty
2021-03-22 22:16 ` Stefan Monnier
2021-03-22 22:39 ` Tomas Hlavaty
2021-03-22 23:27 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4kh9khg2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=arthur.miller@live.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).