From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 6e796b5: Stop project-root from going into infinite recursion Date: Wed, 17 Mar 2021 17:33:13 -0400 Message-ID: References: <20210317164927.28196.12402@vcs0.savannah.gnu.org> <20210317164928.C2C11209AA@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31915"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 17 22:34:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMdoX-0008Bn-Ba for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Mar 2021 22:34:49 +0100 Original-Received: from localhost ([::1]:46962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMdoW-0005Di-6v for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Mar 2021 17:34:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMdn6-0004BR-76 for emacs-devel@gnu.org; Wed, 17 Mar 2021 17:33:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11734) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMdn4-00054Z-22 for emacs-devel@gnu.org; Wed, 17 Mar 2021 17:33:19 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CA9344409FD; Wed, 17 Mar 2021 17:33:16 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9722B44063C; Wed, 17 Mar 2021 17:33:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616016795; bh=yQXIA6ZijwA3R+nA7HPaA9op2IZQ0MK3rYkbdP3G/ts=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WoNWriAAjwprClAOb6phpQZX9jDtpeiDfdLsB6lP0hj6BmgWjl7q8vhKC2dtU7UHG gyJbtjliiemF36YHcTNzXRDcX2Jjy5uDHfHrZVFjhJjmcx99bVA+W1F4uZlELh3xKj QmODndtCgbk0Fu4PI5yUeNqEqYPrKc5KwOt/Vma+1M+zWz2dVBcaJfer7+950RldTd d6v+LbtVv6ffxlSW4ZjxmRXM+YJvyfQFEDnNfadwpIWDSLhSSMulXOpvsdu7sMfZH2 E19q6pi3fY1w4TRI0UggPQpFGQDx9Kf5MMWKFud2ksUT8MYXlzq0Fkc0I2TnP7gBLe Zh9Z9zQcZhJ1A== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 38CF512017E; Wed, 17 Mar 2021 17:33:15 -0400 (EDT) In-Reply-To: <20210317164928.C2C11209AA@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Wed, 17 Mar 2021 12:49:28 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266533 Archived-At: > @@ -215,7 +217,9 @@ It usually contains the main build file, dependencies > configuration file, etc. Though neither is mandatory. > > The directory name must be absolute." > - (car (project-roots project))) > + (if project--within-roots-fallback > + (signal 'cl-no-applicable-method (list 'project-root project)) > + (car (project-roots project)))) I think `cl-call-next-method` is a better choice. Stefan