From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f3aa648: Make `lookup-key' understand the new key sequence syntax Date: Tue, 19 Oct 2021 10:47:55 -0400 Message-ID: References: <20211019030801.23534.79581@vcs0.savannah.gnu.org> <20211019030802.83DE621120@vcs0.savannah.gnu.org> <87wnm9dtee.fsf@gnus.org> <8735oxdrox.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7051"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 19 17:21:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcqvI-0001b0-As for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 17:21:04 +0200 Original-Received: from localhost ([::1]:40902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcqvG-00061R-ST for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 11:21:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcqPK-000796-5D for emacs-devel@gnu.org; Tue, 19 Oct 2021 10:48:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcqPI-0006qs-Ej for emacs-devel@gnu.org; Tue, 19 Oct 2021 10:48:01 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 48940440CCB; Tue, 19 Oct 2021 10:47:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0A81B440C12; Tue, 19 Oct 2021 10:47:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634654877; bh=0K7JLZ/FFMdZmH8QUqTif+1RZgQBTSlwxh1ghJUcHxc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Z/yBI5V/MHBp3BqgJgukNznVta4TCEYfbiUe0kTKzddryo5SDrB3jAPW5NHm6bKMR htFEUCKHhcG65pFSHkAj7wIIUT1fQIt7SRw760+xRsV28K5tbvAOtRcArFYFd/pFR6 7Ii87LrcxThHlaX92aARIHneG2rH6HzqHVURym+zms1zfc1sfXx82gQ5PNa1aLxadJ PRu33AjwQWvZLjVed/2Bh1ZAsrGqkVSEbFhX581lOPHL3MavNFriAH3VMYOZBsug5g auMQ00rcArQ7rRUV95gJ5QKH0v131SolEX+1i5wlAEDD/D83yCm3YNGvMMBwb1I1/S 25mOct6S4CHYQ== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D981D120337; Tue, 19 Oct 2021 10:47:56 -0400 (EDT) In-Reply-To: <8735oxdrox.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Oct 2021 16:17:50 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277379 Archived-At: Lars Ingebrigtsen [2021-10-19 16:17:50] wrote: > Stefan Monnier writes: >> In terms of behavior, no impact: >> >> ELISP> (let ((map (make-sparse-keymap))) (define-key map >> ELISP> [C-M-next] 'dummy) map) >> (keymap (C-M-next . dummy)) >> >> ELISP> (let ((map (make-sparse-keymap))) (define-key map >> ELISP> [M-C-next] 'dummy) map) >> (keymap (C-M-next . dummy)) > > Would this just be a simplification of the innards of `define-key', then? It would move all the canonicalization to a separate function, yes. Stefan