From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds of events Date: Sat, 20 Nov 2021 08:20:53 -0500 Message-ID: References: <20211120075812.24103.86181@vcs0.savannah.gnu.org> <20211120075814.63AB3209FD@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27363"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 20 14:22:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moQJf-0006tP-RF for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Nov 2021 14:22:04 +0100 Original-Received: from localhost ([::1]:56654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moQJe-0007oL-49 for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Nov 2021 08:22:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moQIf-00077g-Rb for emacs-devel@gnu.org; Sat, 20 Nov 2021 08:21:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moQIc-0004TD-7A for emacs-devel@gnu.org; Sat, 20 Nov 2021 08:20:59 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0AD0B80582; Sat, 20 Nov 2021 08:20:56 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 70F3680413; Sat, 20 Nov 2021 08:20:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1637414454; bh=6awxtHarLaYBLqh7GzVfKiLzAKEPWIg35Oeg7NgUa0g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ihi5FpgUgpXjyvyAPU5ylDSxOKFL+eg5Ue7l7v0xGttc26WhcQfdgvFs51U3ZNt15 /oy0+SNYWTd6eF/uy1xMClaa/FZxPtSjyzYhCx3lDqU3yUiun7jAw/ra9vZZwjRqhR 1AsAjADa5JKK+7h3OsrmLb5NklUxCPcKwGeFjcZE2Tk+u5ImPqRKPTtHWQgJuLDR64 JD4Z+Uz3VK/H5dRRYQ7N7we0DPnCUc5W1kcMo3QYW9EXrQzoviibSihPOG9XuqEfw/ OMenUCnV7UKLbOeOh9o8sI6pibAPLZOcgPoMT5j60zKRDoSk2YsIGmxqd0IDCle8oh CpvYEmnaz4t9w== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2A2BF1202F4; Sat, 20 Nov 2021 08:20:54 -0500 (EST) In-Reply-To: <20211120075814.63AB3209FD@vcs0.savannah.gnu.org> (Po Lu's message of "Sat, 20 Nov 2021 02:58:14 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279804 Archived-At: > Fix `browse-url-interactive-arg' for certain kinds of events > > * lisp/net/browse-url.el (browse-url-interactive-arg): Don't > call `mouse-set-point' unless event is actually a mouse event. > --- > lisp/net/browse-url.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el > index 3af37e4..50d11b4 100644 > --- a/lisp/net/browse-url.el > +++ b/lisp/net/browse-url.el > @@ -730,7 +730,8 @@ position clicked before acting. > This function returns a list (URL NEW-WINDOW-FLAG) > for use in `interactive'." > (let ((event (elt (this-command-keys) 0))) > - (and (listp event) (mouse-set-point event))) > + (when (mouse-event-p event) > + (mouse-set-point event))) > (list (read-string prompt (or (and transient-mark-mode mark-active > ;; rfc2396 Appendix E. > (replace-regexp-in-string Shouldn't this be fixed in `mouse-set-point` (or even `event-end` and `event-start`) instead, and then we should remove the `listp` test since `mouse-set-point` nowadays should work with any kind of event. Stefan