From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f8bb6cca33: Return the same file from locate-file in nativecomp and non Date: Sun, 13 Mar 2022 10:26:48 -0400 Message-ID: References: <164712074096.14747.18124931770043811100@vcs2.savannah.gnu.org> <20220312213221.451B3C01684@vcs2.savannah.gnu.org> <87fsnmyh4q.fsf@gnus.org> <87y21eviwn.fsf@gnus.org> <831qz6mlw0.fsf@gnu.org> <87bkyauecx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="807"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 13 15:27:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTPCL-000AVx-D3 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Mar 2022 15:27:53 +0100 Original-Received: from localhost ([::1]:49154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTPCJ-00015Z-Ax for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Mar 2022 10:27:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTPBR-0000Oj-6S for emacs-devel@gnu.org; Sun, 13 Mar 2022 10:26:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTPBO-0004rs-DG; Sun, 13 Mar 2022 10:26:56 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7D6BE80306; Sun, 13 Mar 2022 10:26:51 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5ADAF8056D; Sun, 13 Mar 2022 10:26:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1647181610; bh=dWtrxhe2FV5XNWf8QKYLvk7KaIKs1UnlzdeakCFxvSE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BBEVAjSt682Me1qvzegfG+D75RpCeQginTbHMffZUG7ykW0sjDcyDfnEFlwXK6jH2 GlHw6Y72SsL1FDl5up961XsHGMyznmMBwCuupo5Ot7AT09r+XVFRBi9chQDkOQlsnJ EW6xU2lwmJNi5Si049FB2MitJ1wsrYFQ30XGSXxqGPI93o3ffIxk2KGheM0SfVwC21 7dCoOBWN28r7MHNYkXC1aVatKTX/fk4YPHH9Y87YtkyQBdufG+goDiZXU5FcP/2hb1 6IgJqXnWRcsyEuW0YQ9JhKp6bmYrQe2OpXiQ6WRFMJjII0pvWJSwq0s1PVyG8wdqxK lcxvjXD4NmGPA== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 298551203F3; Sun, 13 Mar 2022 10:26:50 -0400 (EDT) In-Reply-To: <87bkyauecx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Mar 2022 15:16:46 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287067 Archived-At: >> I object to such backward-incompatible change in a public API. Please >> revert that change. > Stefan's patch does not change the behaviour of locate-file (after my > patch). It does change the behaviour of locate-file-internal, but > that's not a public function (and it's only used in locate-file). So > I'm not sure what you mean here. AFAIK it reverts the behavior of `locate-file-internal` to that of Emacs-27, and I think the change in Emacs-28 is just a bug (an oversight, I suspect), so I'd even suggest we install my patch in `emacs-28`. Stefan