From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: use-package Date: Thu, 03 Nov 2022 13:22:16 -0400 Message-ID: References: <87lep4jeeb.fsf@gmail.com> <87bkq0gfc9.fsf@posteo.net> <87v8o80xs1.fsf@gmail.com> <87h6zqgc3s.fsf@gmail.com> <87v8o52mkn.fsf@gmail.com> <87v8o5w2c1.fsf@posteo.net> <877d0kbkfm.fsf@gmail.com> <875yg4144y.fsf@gmail.com> <87h6zmj451.fsf@gmail.com> <5EE58F68-8B9E-4DE6-BA20-3A88FFDA6528@posteo.net> <871qqkjwjj.fsf@gmail.com> <87o7to2dfy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12850"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Philip Kaludercic , John Wiegley , emacs-devel To: Payas Relekar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 03 18:23:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqdvu-0003B2-Ti for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Nov 2022 18:23:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqdvF-0003Gq-Bd; Thu, 03 Nov 2022 13:22:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqdv7-0003Cu-T4 for emacs-devel@gnu.org; Thu, 03 Nov 2022 13:22:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqdv5-0002K3-Hl; Thu, 03 Nov 2022 13:22:25 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6962D803F0; Thu, 3 Nov 2022 13:22:20 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A98168025C; Thu, 3 Nov 2022 13:22:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667496137; bh=tT+vjIiea+eN5DoNMtdQJynCvhlUVolQwd39DSlIPJw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=h7KQGU0iwF26WIHfJpVJdLrMt1rR0fqgp0tLL6r48DAhasEjzAOtANuusooV3vew9 lieDGjzJo6QVmuf3Jy8H9g16S4ZekjQPH2xwosu7ovTshcXSftbAxf68o3AztJBUoS mDu7P6GtG86ZdNRLYfjtHuvYrUCtM8s53QgwA11IQCllfH90GG0qVzdXOTIqAMpX5q TkUW7Sz78a+yNuXa13XxJDf7MEwuip3q7suoataZPXGGPQbAtkQ4QL4W9cWa5Q8DC9 DLQ0CKE9oy9PgP9nl6AP3HAE/Iv7hQFncXc9qUe1hCy6GwGycSSGd9ae7XTkF2ObYA Wq7vX99/BMKvg== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 569B7120A73; Thu, 3 Nov 2022 13:22:17 -0400 (EDT) In-Reply-To: <87o7to2dfy.fsf@gmail.com> (Payas Relekar's message of "Thu, 03 Nov 2022 22:12:09 +0530") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299085 Archived-At: > You crystal ball was right! After pruning worktree the command worked, > but I am quite confused at the output. I've attached the logs for my > attempt to build, can you please check if I did something incorrectly? > In particular the build command fails because it complains makeinfo is > not available, but I clearly have it in path. [...] > ~/g/elpa main $ makeinfo --version > texi2any (GNU texinfo) 6.8 > > Copyright (C) 2021 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > ~/g/elpa main $ make build/use-package > emacs --batch -l /home/payas/git/elpa/admin/elpa-admin.el \ > -f elpaa-batch-make-one-package use-package > Updating worktree in "/home/payas/git/elpa/packages/use-package/" > Updated use-package: > Auto-merging use-package-core.el > Merge made by the 'ort' strategy. > README.md | 4 ++-- > use-package-core.el | 4 ++-- > use-package-tests.el | 7 +++++++ > 3 files changed, 11 insertions(+), 4 deletions(-) > > ======== Building tarball archive-devel/use-package-2.4.4.0.20221103.163652.tar... > Build error for archive-devel/use-package-2.4.4.0.20221103.163652.tar: (error "Error-indicating exit code in elpaa--call-sandboxed: > bwrap: execvp makeinfo: No such file or directory > ") > ######## Build of package archive-devel/use-package-2.4.4.0.20221103.163652.tar FAILED!! The problem comes from `bwrap` here, which our scripts use to try and protect `elpa.gnu.org` from mishaps. Not sure why the command run from `bwrap` can't find `makeinfo`. Maybe your `makeinfo` is not in one of the directories that are accessible within the sandbox (see `elpaa--sandbox-ro-binds` in `.../elpa/admin/elpa-admin.el`)? You should be able to circumvent the problem by editing `elpa-config` and adding (sandbox nil) to it. > Also make after build only seems to build setup-ox-hugo.el. [...] > ~/g/elpa main $ make packages/use-package > Generating description file packages/use-package/use-package-pkg.el > emacs --batch -l admin/elpa-admin.el \ > -f elpaa-batch-generate-autoloads packages/use-package/use-package-autoloads.el > INFO Scraping files for loaddefs... > INFO Scraping files for loaddefs...done > GEN use-package-autoloads.el > Byte compiling packages/use-package/bind-chord.el > Unable to activate package `use-package'. > Required package `bind-key-2.4' is unavailable > Byte compiling packages/use-package/bind-key.el > Unable to activate package `use-package'. > Required package `bind-key-2.4' is unavailable > Byte compiling packages/use-package/doc/setup-ox-hugo.el > Unable to activate package `use-package'. > Required package `bind-key-2.4' is unavailable > > In toplevel form: > packages/use-package/doc/setup-ox-hugo.el:192:51: Warning: reference to free variable `ox-hugo-default-lisp-directory' > packages/use-package/doc/setup-ox-hugo.el:215:21: Warning: reference to free variable `org-emphasis-regexp-components' > packages/use-package/doc/setup-ox-hugo.el:222:33: Warning: Unused lexical argument `file' > packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't use lexical var `ob-lang-alist'; use `push' or `cl-pushnew' > packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't use lexical var `ob-lang-alist'; use `push' or `cl-pushnew' > packages/use-package/doc/setup-ox-hugo.el:230:56: Warning: Unused lexical argument `body' > packages/use-package/doc/setup-ox-hugo.el:238:11: Warning: assignment to free variable `org-confirm-babel-evaluate' > packages/use-package/doc/setup-ox-hugo.el:241:11: Warning: assignment to free variable `org-export-headline-levels' > packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: reference to free variable `org-export-exclude-tags' > packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: assignment to free variable `org-export-exclude-tags' > > In end of data: > packages/use-package/doc/setup-ox-hugo.el:238:40: Warning: the function `ox-hugo-org-confirm-babel-evaluate-fn' is not known to be defined. > packages/use-package/doc/setup-ox-hugo.el:218:4: Warning: the function `org-set-emph-re' is not known to be defined. > packages/use-package/doc/setup-ox-hugo.el:208:4: Warning: the function `org-hugo-export-wim-to-md' is not known to be defined. > packages/use-package/doc/setup-ox-hugo.el:75:49: Warning: the function `vc-git-root' is not known to be defined. > make: *** [GNUmakefile:119: packages/use-package/doc/setup-ox-hugo.elc] Error While the bulk of the output comes from `setup-ox-hugo.el` it's not the only file compile, as we can see several messages of the form: Byte compiling packages/use-package/.el It's just that most of the files have been cleaned up not to emit warnings, whereas `setup-ox-hugo.el` has not enjoyed the same care. > There are also couple of errors, there are couple of errors too, and > I'm not sure if fixing them is worth it. The overall error is because of the `add-to-list` error above encountered during compilation of `setup-ox-hugo.el`. Should be easy to fix, so I'd encourage you to fix those errors and warnings, especially since the rest of the code is "warning-free". > My understanding is that we only need to add copyrights to the file > because entire repo is cloned to GNU machines. But even after adding > copyright headers, IMO adding doc/* to :ignored-files is the right thing > to do as it does not serve users directly. Indeed the two choices are independent. Whether to include the `doc` subdir in the tarball depends on whether the increased tarball size is a problem and whether that `doc` is relevant for users of `use-package`. I don't know enough about what that `doc` holds to give a good recommendation. > ~/g/elpa main ?1 2.7s [2] make build/bind-key > emacs --batch -l /home/payas/git/elpa/admin/elpa-admin.el \ > -f elpaa-batch-make-one-package bind-key > Cloning branch bind-key: > Preparing worktree (new branch 'externals/bind-key') > branch 'externals/bind-key' set up to track 'origin/externals/bind-key'. > HEAD is now at 0be480ea77 Merge pull request #1009 from andreyorst/face-spec-set-third-argument > > ======== Building tarball archive-devel/bind-key-2.4.1.0.20221029.145719.tar... > ######## Built new package archive-devel/bind-key-2.4.1.0.20221029.145719.tar! > ======== Building tarball archive/bind-key-2.4.1.tar... > ######## Built new package archive/bind-key-2.4.1.tar! This worked. > ~/g/elpa main ?1 1.2s ? make packages/bind-key Since both use the same repository, they contain the same files, and so compiling `bind-key` or compiling `use-package` should basically do the same. [ This "compiling" is for in-place installation of the package, where we can't really install `use-package` without also installing `bind-key` and vice-versa. ] Stefan