From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: tramp and diff-mode results in Emacs crash Date: Thu, 01 Mar 2007 00:23:14 -0500 Message-ID: References: <20070222120757.GA28434@morgase.caliginous.net> <20070223235449.GA29688@morgase.caliginous.net> <20070225052253.GA13725@morgase.caliginous.net> <20070225221438.GA16508@morgase.caliginous.net> <87hct73vpw.fsf@stupidchicken.com> <87fy8qb61x.fsf@stupidchicken.com> <87irdlc3zm.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1172726617 25410 80.91.229.12 (1 Mar 2007 05:23:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Mar 2007 05:23:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 01 06:23:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HMdlI-0002gZ-3U for ged-emacs-devel@m.gmane.org; Thu, 01 Mar 2007 06:23:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HMdlJ-0002S6-46 for ged-emacs-devel@m.gmane.org; Thu, 01 Mar 2007 00:23:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HMdl7-0002Rm-Ct for emacs-devel@gnu.org; Thu, 01 Mar 2007 00:23:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HMdl6-0002RW-94 for emacs-devel@gnu.org; Thu, 01 Mar 2007 00:23:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HMdl6-0002RT-3O for emacs-devel@gnu.org; Thu, 01 Mar 2007 00:23:16 -0500 Original-Received: from tomts20.bellnexxia.net ([209.226.175.74] helo=tomts20-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HMdl5-0002vI-ML for emacs-devel@gnu.org; Thu, 01 Mar 2007 00:23:15 -0500 Original-Received: from alfajor.home ([70.55.146.57]) by tomts20-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070301052314.YNEC1637.tomts20-srv.bellnexxia.net@alfajor.home> for ; Thu, 1 Mar 2007 00:23:14 -0500 Original-Received: by alfajor.home (Postfix, from userid 20848) id 1F5461C14E; Thu, 1 Mar 2007 00:23:14 -0500 (EST) In-Reply-To: <87irdlc3zm.fsf@stupidchicken.com> (Chong Yidong's message of "Wed\, 28 Feb 2007 17\:27\:25 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.94 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67103 Archived-At: > So I reverted my previous change, and changed combine-after-change-execute > to return nil when combine_after_change_buffer is not a valid buffer. > This fixes the bug too, and I think it shouldn't be much more > dangerous than the previous workaround. That looks good, thank you. The only problem that I can see with it, is that we end up not running the hooks at all. But there's no much we can do. At best, we could try to run them before killing the buffer (e.g. from Fkill_buffer) but I'm not sure it's worth the trouble. Stefan