unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Font slants
Date: Sat, 05 Apr 2008 16:30:02 -0400	[thread overview]
Message-ID: <jwv3aq0vyia.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <873aq0cdan.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 05 Apr 2008 15:27:44 -0400")

>>> When I do M-x customize-face RET default RET, the value of the `default'
>>> face is given as a Lisp expression instead of the usual value menus.
>>> This occurs because the slant of the face, as supplied by the new font
>>> engine, is "roman".
>> 
>>> I just committed the following patch to fix this.  However, I'm not sure
>>> these are the only values of the slant parameter.  Does anyone know if
>>> other possible values could be generated?
>> 
>> Why not use font-slant-table, font-weight-table, and font-swidth-table?

> There is one problem with that: font-slant-table etc. are defcustoms,
> while custom-face-attributes is a defconst.  So if you want to use them
> to initialize custom-face-attributes, one possibility is to change
> font-slant-table etc into defconsts and move them from faces.el into
> cus-face.el.  Is it even useful to customize these alists?

As long as cus-face is loaded after faces.el, that won't be
a serious problem, since it's probably not very useful to customize
those lists.  I wouldn't have made them customizable, but maybe Handa
had good reasons to do that?

> On a related note, what's the story behind these settings?

> (defcustom font-swidth-table
>   '((ultracondensed . 50) (ultra-condensed . 51)
>   ...

> Why do we have a practically indistinguishable difference between
> ultracondensed and ultra-condensed?  Similarly with several other
> symbols in these alists.

Try to change it (or check vc-annotate) to see why: it needs to be
bijective (ie. reversible).


        Stefan




  reply	other threads:[~2008-04-05 20:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-05 14:46 Font slants Chong Yidong
2008-04-05 18:28 ` Stefan Monnier
2008-04-05 19:27   ` Chong Yidong
2008-04-05 20:30     ` Stefan Monnier [this message]
2008-04-05 21:12       ` Chong Yidong
2008-04-06  1:44         ` Stefan Monnier
2008-04-08  6:06           ` Kenichi Handa
2008-04-05 21:46       ` Chong Yidong
2008-04-06  1:45         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv3aq0vyia.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).