unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Eric S. Raymond" <esr@snark.thyrsus.com>
Cc: emacs-devel@gnu.org
Subject: Re: Redesigh of the VC front end
Date: Mon, 05 May 2008 21:15:37 -0400	[thread overview]
Message-ID: <jwv3aowkzrl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20080506003943.80ED89F054C@snark.thyrsus.com> (Eric S. Raymond's message of "Mon,  5 May 2008 20:39:43 -0400 (EDT)")

> 2. Otherwise, if you are in a vc dired buffer, and
> include-files-not-directories is non-nil, and no fileset is selected,
> select all files at and below directory level.

This is bad.  It should simply return the "file or directory under
point".

> 2. When the backend supports the concept, every vc-dir buffer has a
> special top-line entry that can be marked to select the entire repo.

In PCL-CVS we list subdirectories, including ".", which is hence not
particularly special.  But maybe there's a difference between "." and
"the entire repo".

> So the Dired code has to go, once the vc-dir code is at functional
> parity to it.  This will take a little more work.

In many respects the vc-dir code will never be at parity with vc-dired,
unless we make a special effort to merge it again with dired.  I.e. we
shouldn't forget that some people liked to do dired operations from
vc-dired.

For what it's worth, I don't think that merging the two is necessarily
a bad idea.  But it seems terribly difficult to be able to do such
a combined mode that's both as good as dired and as good as vc-dir.

> that's what the user selected.  This means that file-oriented back ends
> (SCCS, RCS, CVS) will have to do directory expansion for themselves
> when it is needed.

Actually, CVS handles directories just fine in most respects.

> There is also a bit of murk around the handling of unregistered files.
> I haven't completely thought that one out yet.  I think the code can be
> rewritten so that filesets of unregistered files are simply passed to
> the back end, yielding the VCS's own error for this case when the user
> did not select 'register' as the operation.

100% agreement, especially because there may be good reasons for the
user to do that (e.g. if Emacs's notion of registration is buggy, or
out-of-date, or because the backend includes special semantics for them
(e.g. its "commit" operation may automatically add the unregistered
files mentioned on the command line).


        Stefan




  parent reply	other threads:[~2008-05-06  1:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06  0:39 Redesigh of the VC front end Eric S. Raymond
2008-05-06  1:14 ` Dan Nicolaescu
2008-05-06  8:28   ` Eric S. Raymond
2008-05-06 11:38     ` Dan Nicolaescu
2008-05-06 16:24       ` Eric S. Raymond
2008-05-06 16:56         ` Dan Nicolaescu
2008-05-06  1:15 ` Stefan Monnier [this message]
2008-05-06  2:00   ` Dan Nicolaescu
2008-05-06  7:48     ` Eric S. Raymond
2008-05-06 11:44       ` Dan Nicolaescu
2008-05-06 16:22         ` Eric S. Raymond
2008-05-06 16:44           ` Paul R
2008-05-06 17:16             ` Dan Nicolaescu
2008-05-06 17:48               ` Paul R
2008-05-06 18:05                 ` Dan Nicolaescu
2008-05-06 18:22             ` Eric S. Raymond
2008-05-06 19:45               ` Dan Nicolaescu
2008-05-06 20:00                 ` Paul R
2008-05-06 16:45           ` Dan Nicolaescu
2008-05-07  1:38         ` Stefan Monnier
2008-05-07  2:15           ` Dan Nicolaescu
2008-05-07  1:37       ` Stefan Monnier
2008-05-07  4:14         ` Eric S. Raymond
2008-05-07  1:34     ` Stefan Monnier
2008-05-07  2:18       ` Dan Nicolaescu
2008-05-06  8:48   ` Eric S. Raymond
2008-05-06  1:29 ` Karl Fogel
2008-05-06  8:08   ` Eric S. Raymond
2008-05-06  8:18     ` David Kastrup
2008-05-06  8:54       ` Eric S. Raymond
2008-05-06 19:36     ` Karl Fogel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv3aowkzrl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=esr@snark.thyrsus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).