From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-register complains if a file is already registered in a git repository Date: Tue, 21 Oct 2008 17:43:37 -0400 Message-ID: References: <87prlvm2ms.fsf@hagelb.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224625475 11559 80.91.229.12 (21 Oct 2008 21:44:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Oct 2008 21:44:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Phil Hagelberg Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 21 23:45:36 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KsP2j-0005xs-Dc for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 23:45:33 +0200 Original-Received: from localhost ([127.0.0.1]:44001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsP1e-00017p-2e for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 17:44:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KsP13-0000lq-Ec for emacs-devel@gnu.org; Tue, 21 Oct 2008 17:43:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KsP11-0000jk-BE for emacs-devel@gnu.org; Tue, 21 Oct 2008 17:43:48 -0400 Original-Received: from [199.232.76.173] (port=40241 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsP11-0000jN-3j for emacs-devel@gnu.org; Tue, 21 Oct 2008 17:43:47 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:53540) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KsP0z-00017J-Or for emacs-devel@gnu.org; Tue, 21 Oct 2008 17:43:45 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KsP0y-0003EP-KE for emacs-devel@gnu.org; Tue, 21 Oct 2008 17:43:44 -0400 Original-Received: from alfajor.home (vpn-132-204-232-223.acd.umontreal.ca [132.204.232.223]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m9LLiAK4030054; Tue, 21 Oct 2008 17:44:12 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id 4E5461C178; Tue, 21 Oct 2008 17:43:37 -0400 (EDT) In-Reply-To: <87prlvm2ms.fsf@hagelb.org> (Phil Hagelberg's message of "Mon, 20 Oct 2008 13:29:31 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3130=0 X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104788 Archived-At: > Unfortunately when I use vc-register on a file that is already in the > repository, it complains, saying "This file is already registered". This > is a reasonable thing to do in most VC systems, but git behaves > differently since it's a common thing to want to register the changes > you've just made to the git index (or staging area). I'm not sure we want to allow C-x v i to do that. OT1H it might be convenient and maybe it can work well, but OTOH it looks risky and would require changing vc-register more than I'd like. It would probably be better for vc-git to provide another command, for that. We could probably add a `extra-keys' operation similar to `extra-menu' so that vc-git can not only provide a new command but also provide a specific C-x v key binding for it. Stefan