From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
Cc: emacs-devel@gnu.org
Subject: Re: BibTeX completion via completion-in-region
Date: Sat, 05 Dec 2009 11:08:27 -0500 [thread overview]
Message-ID: <jwv3a3pqubv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <19225.59404.211849.447292@regnitz.physics.niu.edu> (Roland Winkler's message of "Fri, 4 Dec 2009 22:56:44 -0600")
>>>>> "Roland" == Roland Winkler <Roland.Winkler@physik.uni-erlangen.de> > - Suppose I want to complete the BibTeX string "AB".
> So I hit TAB while point is past the "AB".
> This gives me a buffer displaying possible completions, for example,
> "ABC" and "ABD".
> Then I select "ABC".
> This will insert the complete string "ABC" so that I get the
> awkward result "ABABC".
> I do not know whether this is related to the fact that
> completion-ignore-case is t in that case.
> (Maybe this is a known problem. There are some comments of that
> kind in minibuffer.el.)
That would be a bug, indeed. Please report it.
> - You greatly shortened the code of bibtex-complete-internal by
> calling completion-in-region. The code calling
> bibtex-complete-internal assumes that this function returns the
> completion. This still seems to work, though completion-in-region
> has no documented return value. So I suggest to make the
> completion the documented return value of completion-in-region.
As you can see in the code, it doesn't return the completion, but yes,
we should document that it returns a boolean. I'll take care of it, no
need for a bug-report.
> - The return value of bibtex-complete-internal is used by
> bibtex-complete-string-cleanup which displays the expansion of the
> BibTeX string. Yet now this message can be hidden by the `Sole
> completion' message issued by minibuffer-complete. Here I am
> actually not sure what would be the best solution. I like the
> message that tells me the expansion of the BibTeX string (I cannot
> and will never be able to remember their meanings...). But I also
> understand that a "Sole completion' message can be helpful. And I
> know for sure that I am annoyed when one of these message is
> delayed by the other.
That's a problem, indeed. Please bug-report it.
Stefan
next prev parent reply other threads:[~2009-12-05 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 4:56 BibTeX completion via completion-in-region Roland Winkler
2009-12-05 16:08 ` Stefan Monnier [this message]
2009-12-05 17:45 ` Roland Winkler
2009-12-05 18:44 ` Stefan Monnier
2009-12-05 19:23 ` Roland Winkler
2009-12-06 0:14 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv3a3pqubv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=Roland.Winkler@physik.uni-erlangen.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).