From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around
Date: Mon, 04 Aug 2014 03:28:30 -0400 [thread overview]
Message-ID: <jwv38dcu347.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1XE9Us-00047U-Id@vcs.savannah.gnu.org> (Dmitry Antipov's message of "Mon, 04 Aug 2014 04:03:42 +0000")
> safe_run_hooks (Lisp_Object hook)
> {
> - /* FIXME: our `internal_condition_case' does not provide any way to pass data
> - to its body or to its handlers other than via globals such as
> - dynamically-bound variables ;-) */
> ptrdiff_t count = SPECPDL_INDEX ();
> +
> specbind (Qinhibit_quit, hook);
> -
> run_hook_with_args (1, &hook, safe_run_hook_funcall);
> -
> unbind_to (count, Qnil);
> }
You remove the comment but don't fix the code accordingly: if the FIXME
is not valid any more, than we should cleanly pass `hook' as argument
rather than let-binding it to inhibit-quit.
Stefan
next parent reply other threads:[~2014-08-04 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XE9Us-00047U-Id@vcs.savannah.gnu.org>
2014-08-04 7:28 ` Stefan Monnier [this message]
2014-08-04 8:28 ` [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around Dmitry Antipov
2014-08-04 22:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv38dcu347.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).