Nonsense in gnus-uu.el

Nonsense in gnus-uu.el

[Stefan Monnier]

Could someone fix the problem below?


        Stefan


diff --git a/lisp/gnus/gnus-uu.el b/lisp/gnus/gnus-uu.el
index 55a881c..f5d4495 100644
--- a/lisp/gnus/gnus-uu.el
+++ b/lisp/gnus/gnus-uu.el
@@ -875,8 +875,13 @@ When called interactively, prompt for REGEXP."
 	(goto-char (setq beg (point-max)))
 	(save-excursion
 	  (save-restriction
+            ;; FIXME: We save excursion and restriction in "*gnus-uu-body*",
+            ;; only to immediately move to another buffer?  And we narrow in
+            ;; that buffer without save-restriction?  And we finish the
+            ;; save-restriction with a call to `widen'?  How can that
+            ;; make sense?
 	    (set-buffer buffer)
-	    (let (buffer-read-only)
+	    (let ((inhibit-read-only t))
 	      (set-text-properties (point-min) (point-max) nil)
 	      ;; These two are necessary for XEmacs 19.12 fascism.
 	      (put-text-property (point-min) (point-max) 'invisible nil)

Re: Nonsense in gnus-uu.el

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Could someone fix the problem below?

[...]

> +            ;; FIXME: We save excursion and restriction in "*gnus-uu-body*",
> +            ;; only to immediately move to another buffer?  And we narrow in
> +            ;; that buffer without save-restriction?  And we finish the
> +            ;; save-restriction with a call to `widen'?  How can that
> +            ;; make sense?

Yeah, that's pretty confused.  I'll try to fix it up...

Hm.  What are the commit rules these days with the ChangeLog-less setup?
It's probably on a web page somewhere...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Nonsense in gnus-uu.el

[Dmitry Gutov]

On 04/15/2015 04:20 PM, Lars Magne Ingebrigtsen wrote:

> Hm.  What are the commit rules these days with the ChangeLog-less setup?
> It's probably on a web page somewhere...

It's in CONTRIBUTE.

Re: Nonsense in gnus-uu.el

[Lars Magne Ingebrigtsen]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 04/15/2015 04:20 PM, Lars Magne Ingebrigtsen wrote:
>
>> Hm.  What are the commit rules these days with the ChangeLog-less setup?
>> It's probably on a web page somewhere...
>
> It's in CONTRIBUTE.

- If you use Emacs VC, one way to format ChangeLog entries is to create
  a top-level ChangeLog file manually, and update it with 'C-x 4 a' as
  usual.  Do not register the ChangeLog file under git; instead, use
  'C-c C-a' to insert its contents into into your *vc-log* buffer.
  Or if `log-edit-hook' includes `log-edit-insert-changelog' (which it
  does by default), they will be filled in for you automatically.

Aha.  Okidoke...

- Alternatively, you can use the vc-dwim command to maintain commit
  messages.  When you create a source directory, run the shell command
  'git-changelog-symlink-init' to create a symbolic link from
  ChangeLog to .git/c/ChangeLog.  Edit this ChangeLog via its symlink
  with Emacs commands like 'C-x 4 a', and commit the change using the
  shell command 'vc-dwim --commit'.  Type 'vc-dwim --help' for more.

I don't have any shell command called git-changelog-symlink-init,
apparently.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Nonsense in gnus-uu.el

[Paul Eggert]

On 04/15/2015 06:37 AM, Lars Magne Ingebrigtsen wrote:
> I don't have any shell command called git-changelog-symlink-init,
> apparently.
It's something you need to define, unfortunately.  'vc-dwim --help' says 
this:

     Here's how to use vc-dwim in a project that does not version-control a
     ChangeLog file.  Create a repository just for your personal 
ChangeLog file
     and make a symlink to it from the top-level directory of the 
project.  For
     projects that use git, I put this tiny auxiliary repository in a 
directory
     named .git/c.  You can use this bash/zsh alias to set it up and to 
create
     the symlink:

         git-changelog-symlink-init()
         {
             local d=.git/c
             test -d .git || return 1
             mkdir $d
             touch $d/ChangeLog
             (cd $d && git init && git add ChangeLog && git commit -m. -a)
             ln --backup -s $d/ChangeLog .
         }

Re: Nonsense in gnus-uu.el

[Lars Magne Ingebrigtsen]

Paul Eggert <eggert@cs.ucla.edu> writes:

> It's something you need to define, unfortunately.  'vc-dwim --help'
> says this:

Perhaps that should be a script in the admin directory?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Nonsense in gnus-uu.el

[Paul Eggert]

Lars Magne Ingebrigtsen wrote:
> Perhaps that should be a script in the admin directory?

Better yet, it should be a vc-dwim option.  I've filed this as Bug#20341.