From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Nonsense in gnus-uu.el
Date: Fri, 10 Apr 2015 10:42:11 -0400 [thread overview]
Message-ID: <jwv3848hwpy.fsf-monnier+emacs@gnu.org> (raw)
Could someone fix the problem below?
Stefan
diff --git a/lisp/gnus/gnus-uu.el b/lisp/gnus/gnus-uu.el
index 55a881c..f5d4495 100644
--- a/lisp/gnus/gnus-uu.el
+++ b/lisp/gnus/gnus-uu.el
@@ -875,8 +875,13 @@ When called interactively, prompt for REGEXP."
(goto-char (setq beg (point-max)))
(save-excursion
(save-restriction
+ ;; FIXME: We save excursion and restriction in "*gnus-uu-body*",
+ ;; only to immediately move to another buffer? And we narrow in
+ ;; that buffer without save-restriction? And we finish the
+ ;; save-restriction with a call to `widen'? How can that
+ ;; make sense?
(set-buffer buffer)
- (let (buffer-read-only)
+ (let ((inhibit-read-only t))
(set-text-properties (point-min) (point-max) nil)
;; These two are necessary for XEmacs 19.12 fascism.
(put-text-property (point-min) (point-max) 'invisible nil)
next reply other threads:[~2015-04-10 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 14:42 Stefan Monnier [this message]
2015-04-15 13:20 ` Nonsense in gnus-uu.el Lars Magne Ingebrigtsen
2015-04-15 13:30 ` Dmitry Gutov
2015-04-15 13:37 ` Lars Magne Ingebrigtsen
2015-04-15 17:53 ` Paul Eggert
2015-04-15 17:55 ` Lars Magne Ingebrigtsen
2015-04-15 22:59 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv3848hwpy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).