Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el
       [not found] ` <E1Yhmj2-0007r4-Kx@vcs.savannah.gnu.org>
@ 2015-04-13 23:35   ` Glenn Morris
  2015-04-14  1:24     ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2015-04-13 23:35 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

Stefan Monnier wrote:

> --- a/lisp/loadup.el
> +++ b/lisp/loadup.el
> @@ -103,7 +103,6 @@
>  (load "bindings")
>  ;; This sets temporary-file-directory, used by eg
>  ;; auto-save-file-name-transforms in files.el.

^^^^^^^
The above comment refers to cus-start, and was meant to indicate that
cus-start should not be moved after files.

> -(load "cus-start")
>  (load "window")  ; Needed here for `replace-buffer-in-windows'.
>  (setq load-source-file-function 'load-with-code-conversion)
>  (load "files")
> @@ -144,6 +143,7 @@
>    ;; In case loaddefs hasn't been generated yet.
>    (file-error (load "ldefs-boot.el")))
>  
> +(load "cus-start")                    ;After loaddefs to autoload pcase-dolist.
>  (load "emacs-lisp/nadvice")
>  (load "emacs-lisp/cl-preloaded")
>  (load "minibuffer")            ;After loaddefs, for define-minor-mode.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el
  2015-04-13 23:35   ` master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el Glenn Morris
@ 2015-04-14  1:24     ` Stefan Monnier
  2015-04-14  6:34       ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2015-04-14  1:24 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

>> --- a/lisp/loadup.el
>> +++ b/lisp/loadup.el
>> @@ -103,7 +103,6 @@
>> (load "bindings")
>> ;; This sets temporary-file-directory, used by eg
>> ;; auto-save-file-name-transforms in files.el.
> ^^^^^^^
> The above comment refers to cus-start, and was meant to indicate that
> cus-start should not be moved after files.

Hmm... According to files.el auto-save-file-name-transforms is
initialized with custom-initialize-delay, so its default value will be
(re)set when the dumped Emacs is started, at which point cus-start.el
has clearly been loaded.

Is the value of auto-save-file-name-transforms of importance during the
dumping process itself?


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el
  2015-04-14  1:24     ` Stefan Monnier
@ 2015-04-14  6:34       ` Glenn Morris
  2015-04-14 13:12         ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2015-04-14  6:34 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

I dunno.

IMO it's simpler to go back to not using pcase in cus-start, rather than
check whether every single option cus-start sets is needed in any of the
other files loadup used to load after cus-start and now loads before;
but YMMV.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el
  2015-04-14  6:34       ` Glenn Morris
@ 2015-04-14 13:12         ` Stefan Monnier
  2015-04-15 15:40           ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2015-04-14 13:12 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> IMO it's simpler to go back to not using pcase in cus-start, rather than
> check whether every single option cus-start sets is needed in any of the
> other files loadup used to load after cus-start and now loads before;
> but YMMV.

So far I haven't seen any downside, and conceptually cus-start (which
mostly sets stuff for easy customization and is hence mostly a UI file)
should be loaded late, in my opinion.


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el
  2015-04-14 13:12         ` Stefan Monnier
@ 2015-04-15 15:40           ` Glenn Morris
  2015-04-15 17:03             ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2015-04-15 15:40 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

I think your change causes auto-save-file-name-transforms to show up in
customize-rogue output. I imagine this doesn't bother you, so please
just delete the now-irrelevant comment if you aren't moving the load back.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el
  2015-04-15 15:40           ` Glenn Morris
@ 2015-04-15 17:03             ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2015-04-15 17:03 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> I think your change causes auto-save-file-name-transforms to show up in
> customize-rogue output. I imagine this doesn't bother you, so please
> just delete the now-irrelevant comment if you aren't moving the load back.

I deleted the comment, fixed the rogue, and moved cus-start even later
to reduce the customize-rogues a bit further.


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-04-15 17:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20150413222104.30156.27721@vcs.savannah.gnu.org>
     [not found] ` <E1Yhmj2-0007r4-Kx@vcs.savannah.gnu.org>
2015-04-13 23:35   ` master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el Glenn Morris
2015-04-14  1:24     ` Stefan Monnier
2015-04-14  6:34       ` Glenn Morris
2015-04-14 13:12         ` Stefan Monnier
2015-04-15 15:40           ` Glenn Morris
2015-04-15 17:03             ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).