unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: fixing an Elpa package
Date: Sat, 18 Apr 2015 13:27:09 -0400	[thread overview]
Message-ID: <jwv383xtkuy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a8y5ih6c.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 18 Apr 2015 23:34:35 +0800")

> I originally incorporated the package into Elpa as a subtree, squashed
> into one commit, from a repository elsewhere on my filesystem that is
> linked with Github. Since then there are now four commits to this
> subtree in Elpa, two of them squashes from the external repository.

If I didn't warn you not to squash, then I'm sorry I failed to do that.
Why did you squash in the first place?

> In the meantime, my old computer died and I got a new one.  So I
> re-cloned both the Elpa repository and the Github-based repository onto
> the new machine. If I add my Github-based repository as a remote in the
> Elpa repository, then fetch and subtree-merge, Git tells me there are no
> common commits, and wants to merge in all (317) commits from the
> external repository.

Is the Github repository using different hashes from the old one from
which you merged (with squashing)?

> I guess that makes sense from Git's point of view,

If the hashes are the same, then I don't see why it makes sense.

> but I don't want to pollute Elpa with all those commits.

Merging subtrees with full history, is the way I recommend people do it
and the way it's done for most of the current subtrees, AFAIK.
After all, if it's installed as an "external" we also end up with "all
those commits".

> I'm not sure it would even work, either.

I can't see why not.

> Granted, it was probably a bad idea to take the subtree approach to
> begin with.

It's not set in stone.  So to fix this, we can either do a proper
(non-squashed) "git subtree" merge, or we can switch to a (non-squashed
either) external tree.


        Stefan



  reply	other threads:[~2015-04-18 17:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 15:34 fixing an Elpa package Eric Abrahamsen
2015-04-18 17:27 ` Stefan Monnier [this message]
2015-04-19  3:41   ` Eric Abrahamsen
2015-04-20  1:52     ` Stefan Monnier
2015-04-20  5:04       ` Eric Abrahamsen
2015-04-20 12:34         ` Stefan Monnier
2015-04-23  9:20           ` Eric Abrahamsen
2015-04-23 13:19             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv383xtkuy.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).