Re: [elpa] master 1d46de7 07/50: removed lexical-binding: t (confusing because not necessary)

Re: [elpa] master 1d46de7 07/50: removed lexical-binding: t (confusing because not necessary)

[Stefan Monnier]

>     removed lexical-binding: t (confusing because not necessary)

In which sense is it confusing?

lexical-binding:t is expected to be "the standard" for new Elisp code.
It has various advantages such as giving more precise/detailed warnings,
have cleaner semantics, and even better performance (tho this is largely
hypothetical/theoretical for now).



        Stefan

Re: [elpa] master 0caf472 02/50: increased def value of on-screen-delay

[Stefan Monnier]

> -(defcustom on-screen-delay 3
> +(defcustom on-screen-delay 5
>    "How long `on-screen-mode' should display optical aids."
>    :group 'on-screen :type 'number)
 
The :group argument is redundant in those defcustoms, since it would
default to the latest group defined in the current file, i.e. to
`on-screen', anyway.


        Stefan

Re: [elpa] master 350a979 23/50: add workaround for bug#16796

[Stefan Monnier]

>     add workaround for bug#16796

Do you still see this bug in Emacs-25?


        Stefan

Re: [elpa] master c083518 09/50: added homepage to header

[Stefan Monnier]

> +;; Homepage: https://github.com/michael-heerdegen/on-screen.el

GNU ELPA's standard pseudo-header for that is "URL:".


        Stefan

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[Stefan Monnier]

> +;; Copyright (C) 2013 - 2015 Michael Heerdegen
> +;;               2015 Free Software Foundation, Inc
 
I think this is wrong: I think it should be

   ;; Copyright (C) 2013-2015 Free Software Foundation, Inc


        Stefan

Re: [elpa] master 1d46de7 07/50: removed lexical-binding: t (confusing because not necessary)

[Michael Heerdegen]

Hi Stefan,

the new commits you see result from something I did today: trying to
convert on-screen to a subtree, while it was already developed as an
ordinary package on Elpa.  So I had to merge, I hope everything is
alright.  The actually new changes are minimal.  Most of the stuff are
just very old commits that have now just become "official" part of the
Elpa repo.

> >     removed lexical-binding: t (confusing because not necessary)
>
> In which sense is it confusing?

To be honest, I don't know what I was thinking at that moment.  I added
it back later.  I guess it was just nonsense.


Michael.

Re: [elpa] master 0caf472 02/50: increased def value of on-screen-delay

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> The :group argument is redundant in those defcustoms, since it would
> default to the latest group defined in the current file, i.e. to
> `on-screen', anyway.

Yip, I've already fixed this today, it's included in the merge commit,
thanks.


Michael.

Re: [elpa] master c083518 09/50: added homepage to header

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > +;; Homepage: https://github.com/michael-heerdegen/on-screen.el
>
> GNU ELPA's standard pseudo-header for that is "URL:".

Fixed, thanks.  At that moment, the thing had not been on Elpa yet.  I
missed to correct this when I performed the merge.

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > +;; Copyright (C) 2013 - 2015 Michael Heerdegen
> > +;;               2015 Free Software Foundation, Inc
>  
> I think this is wrong: I think it should be
>
>    ;; Copyright (C) 2013-2015 Free Software Foundation, Inc

Are you sure?  Can I do this retroactively?  I added the package to Elpa
two weeks ago.  Before that, the Copyright was 2013 - 2015 Michael
Heerdegen.  But now those old commits are part of the Elpa repo.  Mmh.
I'm ok with changing it, if it makes sense to you.

Re: [elpa] master 350a979 23/50: add workaround for bug#16796

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> >     add workaround for bug#16796
>
> Do you still see this bug in Emacs-25?

At least the recipe I provided in that bug report doesn't seem to be
reproducible any longer.

I'll comment the fix out and see what will happen.


Michael.

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[Stefan Monnier]

> Are you sure?  Can I do this retroactively?

I don't expect you to change the old versions of the file, but the new
version should state that the FSF copyright (now) applies to the past
as well.
IANAL, but that's what we've always done.


        Stefan

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > Are you sure?  Can I do this retroactively?
>
> I don't expect you to change the old versions of the file, but the new
> version should state that the FSF copyright (now) applies to the past
> as well.
> IANAL, but that's what we've always done.

Ok, I've done that now, thanks.

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[David Kastrup]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Are you sure?  Can I do this retroactively?
>
> I don't expect you to change the old versions of the file, but the new
> version should state that the FSF copyright (now) applies to the past
> as well.
> IANAL, but that's what we've always done.

That's what copyright assignment for past and future changes means.  It
does not mean that the FSF has written any of those changes, just that
you transferred your copyright interests to them.  And the year numbers
are not the years of the transfer, but the year of the copyright's
origin which usually is the date of "first publication".  If you have
never published the stuff previously in any manner, copyright starts
ticking in 2015.  If you did in some publicly accessible manner,
copyright starts ticking at the time you did.

-- 
David Kastrup

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > Are you sure?  Can I do this retroactively?

  > I don't expect you to change the old versions of the file, but the new
  > version should state that the FSF copyright (now) applies to the past
  > as well.
  > IANAL, but that's what we've always done.

That's correct.

If you've assigned your copyright to the FSF,
then the old version copyrights are now the FSF's too.

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Re: [elpa] master d08c167 48/50: on-screen: merge from remote repo

[Michael Heerdegen]

Richard Stallman <rms@gnu.org> writes:

> That's correct.
>
> If you've assigned your copyright to the FSF,
> then the old version copyrights are now the FSF's too.

Ok, good to know, thanks for the clarification.


Michael.